Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 27030009: Revert "Make compositingState explicit (re-land #2 with bogus ASSERT removed)" (Closed)

Created:
7 years, 2 months ago by shawnsingh
Modified:
7 years, 2 months ago
Reviewers:
CC:
blink-reviews, shans, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, pdr, loislo+blink_chromium.org, aandrey+blink_chromium.org, dino_apple.com, blink-layers+watch_chromium.org, caseq+blink_chromium.org, Steve Block, alancutter (OOO until 2018), pfeldman+blink_chromium.org, yurys+blink_chromium.org, dstockwell, Timothy Loh, jchaffraix+rendering, devtools-reviews_chromium.org, Eric Willigers, kenneth.christiansen, rjwright, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, alph+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, Mike Lawther (Google), f(malita), Stephen Chennney
Visibility:
Public.

Description

Revert "Make compositingState explicit (re-land #2 with bogus ASSERT removed)" This is in an attempt to remove the crashing occurring on tip of tree. There's no strong reason to suspect this patch except that this patch was a bit large. BUG=306096 TBR=kareng@chromium.org, vollick@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159473

Patch Set 1 #

Patch Set 2 : fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -190 lines) Patch
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/frame/animation/AnimationBase.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/frame/animation/ImplicitAnimation.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/frame/animation/KeyframeAnimation.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 3 chunks +4 lines, -7 lines 0 comments Download
M Source/core/rendering/CompositedLayerMapping.cpp View 6 chunks +8 lines, -17 lines 0 comments Download
D Source/core/rendering/CompositingState.h View 1 chunk +0 lines, -25 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderLayer.h View 1 2 chunks +5 lines, -12 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 26 chunks +30 lines, -51 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.cpp View 20 chunks +20 lines, -21 lines 0 comments Download
M Source/core/rendering/RenderLayerRepainter.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 5 chunks +10 lines, -12 lines 0 comments Download
M Source/core/rendering/RenderTreeAsText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderView.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M Source/core/rendering/RenderWidget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRenderingContext.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/web/LinkHighlight.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/ScrollingCoordinatorChromiumTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
shawnsingh
7 years, 2 months ago (2013-10-11 19:59:29 UTC) #1
Message was sent while issue was closed.
Committed patchset #2 manually as r159473 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698