Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1242)

Unified Diff: Source/core/rendering/RenderBoxModelObject.cpp

Issue 27030009: Revert "Make compositingState explicit (re-land #2 with bogus ASSERT removed)" (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix build error Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderLayer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderBoxModelObject.cpp
diff --git a/Source/core/rendering/RenderBoxModelObject.cpp b/Source/core/rendering/RenderBoxModelObject.cpp
index 1621701c89adf00d52a5dcc41135d669ae0be12e..bafeec46cf193a685c88d70aa0452e563ac75577 100644
--- a/Source/core/rendering/RenderBoxModelObject.cpp
+++ b/Source/core/rendering/RenderBoxModelObject.cpp
@@ -102,49 +102,49 @@ bool RenderBoxModelObject::hasAcceleratedCompositing() const
bool RenderBoxModelObject::startTransition(double timeOffset, CSSPropertyID propertyId, const RenderStyle* fromStyle, const RenderStyle* toStyle)
{
ASSERT(hasLayer());
- ASSERT(compositingState() == PaintsIntoOwnBacking);
+ ASSERT(isComposited());
return layer()->compositedLayerMapping()->startTransition(timeOffset, propertyId, fromStyle, toStyle);
}
void RenderBoxModelObject::transitionPaused(double timeOffset, CSSPropertyID propertyId)
{
ASSERT(hasLayer());
- ASSERT(compositingState() == PaintsIntoOwnBacking);
+ ASSERT(isComposited());
layer()->compositedLayerMapping()->transitionPaused(timeOffset, propertyId);
}
void RenderBoxModelObject::transitionFinished(CSSPropertyID propertyId)
{
ASSERT(hasLayer());
- ASSERT(compositingState() == PaintsIntoOwnBacking);
+ ASSERT(isComposited());
layer()->compositedLayerMapping()->transitionFinished(propertyId);
}
bool RenderBoxModelObject::startAnimation(double timeOffset, const CSSAnimationData* animation, const KeyframeList& keyframes)
{
ASSERT(hasLayer());
- ASSERT(compositingState() == PaintsIntoOwnBacking);
+ ASSERT(isComposited());
return layer()->compositedLayerMapping()->startAnimation(timeOffset, animation, keyframes);
}
void RenderBoxModelObject::animationPaused(double timeOffset, const String& name)
{
ASSERT(hasLayer());
- ASSERT(compositingState() == PaintsIntoOwnBacking);
+ ASSERT(isComposited());
layer()->compositedLayerMapping()->animationPaused(timeOffset, name);
}
void RenderBoxModelObject::animationFinished(const String& name)
{
ASSERT(hasLayer());
- ASSERT(compositingState() == PaintsIntoOwnBacking);
+ ASSERT(isComposited());
layer()->compositedLayerMapping()->animationFinished(name);
}
void RenderBoxModelObject::suspendAnimations(double time)
{
ASSERT(hasLayer());
- ASSERT(compositingState() == PaintsIntoOwnBacking);
+ ASSERT(isComposited());
layer()->compositedLayerMapping()->suspendAnimations(time);
}
@@ -984,7 +984,7 @@ bool RenderBoxModelObject::fixedBackgroundPaintsInLocalCoordinates() const
return false;
RenderLayer* rootLayer = view()->layer();
- if (!rootLayer || rootLayer->compositingState() == NotComposited)
+ if (!rootLayer || !rootLayer->isComposited())
return false;
return rootLayer->compositedLayerMapping()->backgroundLayerPaintsFixedRootBackground();
« no previous file with comments | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderLayer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698