Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Side by Side Diff: Source/core/frame/FrameView.cpp

Issue 27030009: Revert "Make compositingState explicit (re-land #2 with bogus ASSERT removed)" (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix build error Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1241 matching lines...) Expand 10 before | Expand all | Expand 10 after
1252 { 1252 {
1253 for (Frame* frame = m_frame.get(); frame; frame = frame->tree()->traverseNex t(m_frame.get())) { 1253 for (Frame* frame = m_frame.get(); frame; frame = frame->tree()->traverseNex t(m_frame.get())) {
1254 if (FrameView* view = frame->view()) 1254 if (FrameView* view = frame->view())
1255 view->setCanBlitOnScroll(!view->useSlowRepaints()); 1255 view->setCanBlitOnScroll(!view->useSlowRepaints());
1256 } 1256 }
1257 } 1257 }
1258 1258
1259 bool FrameView::contentsInCompositedLayer() const 1259 bool FrameView::contentsInCompositedLayer() const
1260 { 1260 {
1261 RenderView* renderView = this->renderView(); 1261 RenderView* renderView = this->renderView();
1262 if (renderView && renderView->compositingState() == PaintsIntoOwnBacking) { 1262 if (renderView && renderView->isComposited()) {
1263 GraphicsLayer* layer = renderView->layer()->compositedLayerMapping()->ma inGraphicsLayer(); 1263 GraphicsLayer* layer = renderView->layer()->compositedLayerMapping()->ma inGraphicsLayer();
1264 if (layer && layer->drawsContent()) 1264 if (layer && layer->drawsContent())
1265 return true; 1265 return true;
1266 } 1266 }
1267 1267
1268 return false; 1268 return false;
1269 } 1269 }
1270 1270
1271 void FrameView::setCannotBlitToWindow() 1271 void FrameView::setCannotBlitToWindow()
1272 { 1272 {
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
1369 ViewportConstrainedObjectSet::const_iterator end = m_viewportConstrainedObje cts->end(); 1369 ViewportConstrainedObjectSet::const_iterator end = m_viewportConstrainedObje cts->end();
1370 for (ViewportConstrainedObjectSet::const_iterator it = m_viewportConstrained Objects->begin(); it != end; ++it) { 1370 for (ViewportConstrainedObjectSet::const_iterator it = m_viewportConstrained Objects->begin(); it != end; ++it) {
1371 RenderObject* renderer = *it; 1371 RenderObject* renderer = *it;
1372 if (!renderer->style()->hasViewportConstrainedPosition()) 1372 if (!renderer->style()->hasViewportConstrainedPosition())
1373 continue; 1373 continue;
1374 1374
1375 // Fixed items should always have layers. 1375 // Fixed items should always have layers.
1376 ASSERT(renderer->hasLayer()); 1376 ASSERT(renderer->hasLayer());
1377 RenderLayer* layer = toRenderBoxModelObject(renderer)->layer(); 1377 RenderLayer* layer = toRenderBoxModelObject(renderer)->layer();
1378 1378
1379 // Layers that paint into their ancestor or into a grouped backing will still need 1379 // Composited layers may still actually paint into their ancestor.
1380 // to apply a repaint invalidation. If the layer paints into its own bac king, then 1380 // If that happens, the viewport constrained object needs to be
1381 // it does not need repainting just to scroll. 1381 // repainted on scroll.
1382 if (layer->compositingState() == PaintsIntoOwnBacking) 1382 if (layer->isComposited() && !layer->compositedLayerMapping()->paintsInt oCompositedAncestor())
1383 continue; 1383 continue;
1384 1384
1385 if (layer->viewportConstrainedNotCompositedReason() == RenderLayer::NotC ompositedForBoundsOutOfView 1385 if (layer->viewportConstrainedNotCompositedReason() == RenderLayer::NotC ompositedForBoundsOutOfView
1386 || layer->viewportConstrainedNotCompositedReason() == RenderLayer::N otCompositedForNoVisibleContent) { 1386 || layer->viewportConstrainedNotCompositedReason() == RenderLayer::N otCompositedForNoVisibleContent) {
1387 // Don't invalidate for invisible fixed layers. 1387 // Don't invalidate for invisible fixed layers.
1388 continue; 1388 continue;
1389 } 1389 }
1390 1390
1391 if (layer->hasAncestorWithFilterOutsets()) { 1391 if (layer->hasAncestorWithFilterOutsets()) {
1392 // If the fixed layer has a blur/drop-shadow filter applied on at le ast one of its parents, we cannot 1392 // If the fixed layer has a blur/drop-shadow filter applied on at le ast one of its parents, we cannot
(...skipping 2065 matching lines...) Expand 10 before | Expand all | Expand 10 after
3458 void FrameView::setLayoutSizeInternal(const IntSize& size) 3458 void FrameView::setLayoutSizeInternal(const IntSize& size)
3459 { 3459 {
3460 if (m_layoutSize == size) 3460 if (m_layoutSize == size)
3461 return; 3461 return;
3462 3462
3463 m_layoutSize = size; 3463 m_layoutSize = size;
3464 contentsResized(); 3464 contentsResized();
3465 } 3465 }
3466 3466
3467 } // namespace WebCore 3467 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/css/CSSComputedStyleDeclaration.cpp ('k') | Source/core/frame/animation/AnimationBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698