Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: Source/core/frame/FrameView.cpp

Issue 27030009: Revert "Make compositingState explicit (re-land #2 with bogus ASSERT removed)" (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix build error Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSComputedStyleDeclaration.cpp ('k') | Source/core/frame/animation/AnimationBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index 54f061d373455b45f334ac84a9e3ecc822b79fea..44aeb8ca5e4ac4e2a755ec008940d72f321ac1ff 100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -1259,7 +1259,7 @@ void FrameView::updateCanBlitOnScrollRecursively()
bool FrameView::contentsInCompositedLayer() const
{
RenderView* renderView = this->renderView();
- if (renderView && renderView->compositingState() == PaintsIntoOwnBacking) {
+ if (renderView && renderView->isComposited()) {
GraphicsLayer* layer = renderView->layer()->compositedLayerMapping()->mainGraphicsLayer();
if (layer && layer->drawsContent())
return true;
@@ -1376,10 +1376,10 @@ bool FrameView::scrollContentsFastPath(const IntSize& scrollDelta, const IntRect
ASSERT(renderer->hasLayer());
RenderLayer* layer = toRenderBoxModelObject(renderer)->layer();
- // Layers that paint into their ancestor or into a grouped backing will still need
- // to apply a repaint invalidation. If the layer paints into its own backing, then
- // it does not need repainting just to scroll.
- if (layer->compositingState() == PaintsIntoOwnBacking)
+ // Composited layers may still actually paint into their ancestor.
+ // If that happens, the viewport constrained object needs to be
+ // repainted on scroll.
+ if (layer->isComposited() && !layer->compositedLayerMapping()->paintsIntoCompositedAncestor())
continue;
if (layer->viewportConstrainedNotCompositedReason() == RenderLayer::NotCompositedForBoundsOutOfView
« no previous file with comments | « Source/core/css/CSSComputedStyleDeclaration.cpp ('k') | Source/core/frame/animation/AnimationBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698