Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Side by Side Diff: Source/core/rendering/RenderView.cpp

Issue 27030009: Revert "Make compositingState explicit (re-land #2 with bogus ASSERT removed)" (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix build error Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderTreeAsText.cpp ('k') | Source/core/rendering/RenderWidget.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 421 matching lines...) Expand 10 before | Expand all | Expand 10 after
432 432
433 ANNOTATE_GRAPHICS_CONTEXT(paintInfo, this); 433 ANNOTATE_GRAPHICS_CONTEXT(paintInfo, this);
434 434
435 // This avoids painting garbage between columns if there is a column gap. 435 // This avoids painting garbage between columns if there is a column gap.
436 if (m_frameView && m_frameView->pagination().mode != Pagination::Unpaginated ) 436 if (m_frameView && m_frameView->pagination().mode != Pagination::Unpaginated )
437 paintInfo.context->fillRect(paintInfo.rect, m_frameView->baseBackgroundC olor()); 437 paintInfo.context->fillRect(paintInfo.rect, m_frameView->baseBackgroundC olor());
438 438
439 paintObject(paintInfo, paintOffset); 439 paintObject(paintInfo, paintOffset);
440 } 440 }
441 441
442 static inline bool isComposited(RenderObject* object)
443 {
444 return object->hasLayer() && toRenderLayerModelObject(object)->layer()->isCo mposited();
445 }
446
442 static inline bool rendererObscuresBackground(RenderObject* rootObject) 447 static inline bool rendererObscuresBackground(RenderObject* rootObject)
443 { 448 {
444 if (!rootObject) 449 if (!rootObject)
445 return false; 450 return false;
446 451
447 RenderStyle* style = rootObject->style(); 452 RenderStyle* style = rootObject->style();
448 if (style->visibility() != VISIBLE 453 if (style->visibility() != VISIBLE
449 || style->opacity() != 1 454 || style->opacity() != 1
450 || style->hasTransform()) 455 || style->hasTransform())
451 return false; 456 return false;
452 457
453 if (rootObject->compositingState() == PaintsIntoOwnBacking) 458 if (isComposited(rootObject))
454 return false; 459 return false;
455 460
456 const RenderObject* rootRenderer = rootObject->rendererForRootBackground(); 461 const RenderObject* rootRenderer = rootObject->rendererForRootBackground();
457 if (rootRenderer->style()->backgroundClip() == TextFillBox) 462 if (rootRenderer->style()->backgroundClip() == TextFillBox)
458 return false; 463 return false;
459 464
460 return true; 465 return true;
461 } 466 }
462 467
463 void RenderView::paintBoxDecorations(PaintInfo& paintInfo, const LayoutPoint&) 468 void RenderView::paintBoxDecorations(PaintInfo& paintInfo, const LayoutPoint&)
(...skipping 762 matching lines...) Expand 10 before | Expand all | Expand 10 after
1226 #endif 1231 #endif
1227 1232
1228 if (layoutState) 1233 if (layoutState)
1229 layoutState->m_isPaginated = m_fragmenting; 1234 layoutState->m_isPaginated = m_fragmenting;
1230 1235
1231 if (m_flowThreadState != RenderObject::NotInsideFlowThread) 1236 if (m_flowThreadState != RenderObject::NotInsideFlowThread)
1232 m_root->setFlowThreadStateIncludingDescendants(m_flowThreadState); 1237 m_root->setFlowThreadStateIncludingDescendants(m_flowThreadState);
1233 } 1238 }
1234 1239
1235 } // namespace WebCore 1240 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderTreeAsText.cpp ('k') | Source/core/rendering/RenderWidget.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698