Compile more Gallery targets in gyp v2.

Compile more Gallery targets in gyp v2.

BUG=636289
TEST=run_compiler. Manually confirmed Gallery show images as before.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2702403008
Cr-Commit-Position: refs/heads/master@{#452769}
Committed: https://chromium.googlesource.com/chromium/src/+/f9c3dc95e104c9b8284652b05e649cc17a14cd1c

[oka, 2017-02-23 09:34:23]

Description was changed from

==========
Compile more gallery targets in gyp v2.

BUG=636289
TEST=run_compiler.
==========

to

==========
Compile more gallery targets in gyp v2.

BUG=636289
TEST=run_compiler.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-02-23 09:35:25]

.

[oka, 2017-02-23 09:38:34]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 09:38:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2017-02-23 09:39:26]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 09:39:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2017-02-23 09:45:12]

Description was changed from

==========
Compile more gallery targets in gyp v2.

BUG=636289
TEST=run_compiler.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile more Gallery targets in gyp v2.

BUG=636289
TEST=run_compiler.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-02-23 09:45:12]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2017-02-23 09:45:23]

PTAL.

[oka, 2017-02-23 11:00:43]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 11:00:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2017-02-23 11:03:44]

.

[oka, 2017-02-23 11:03:48]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 11:04:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2017-02-23 11:08:30]

Description was changed from

==========
Compile more Gallery targets in gyp v2.

BUG=636289
TEST=run_compiler.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile more Gallery targets in gyp v2.

BUG=636289
TEST=run_compiler. Manually confirmed Gallery show images as before.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-02-23 11:21:42]

.

[oka, 2017-02-23 11:29:41]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 11:29:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2017-02-23 11:29:50]

.

[oka, 2017-02-23 11:29:53]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 11:30:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 11:56:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 11:56:35]

Dry run: This issue passed the CQ dry run.

[fukino, 2017-02-24 05:06:48]

https://codereview.chromium.org/2702403008/diff/70001/ui/file_manager/gallery...
File ui/file_manager/gallery/js/gallery.js (right):

https://codereview.chromium.org/2702403008/diff/70001/ui/file_manager/gallery...
ui/file_manager/gallery/js/gallery.js:233: * @private
Drop @private (or append _ to the constant name)

https://codereview.chromium.org/2702403008/diff/70001/ui/file_manager/gallery...
ui/file_manager/gallery/js/gallery.js:241: * @private
ditto

https://codereview.chromium.org/2702403008/diff/70001/ui/file_manager/gallery...
ui/file_manager/gallery/js/gallery.js:918: * @private
ditto

https://codereview.chromium.org/2702403008/diff/70001/ui/file_manager/gallery...
ui/file_manager/gallery/js/gallery.js:925: * @private
ditto

[oka, 2017-02-24 05:33:58]

Added _ suffix to private constant and formatted.

[oka, 2017-02-24 05:36:05]

PTAL.

[oka, 2017-02-24 05:36:19]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 05:36:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fukino, 2017-02-24 05:43:17]

lgtm

[oka, 2017-02-24 05:49:34]

The CQ bit was unchecked by oka@chromium.org

[oka, 2017-02-24 05:49:34]

The CQ bit was checked by oka@chromium.org

[oka, 2017-02-24 05:49:43]

The CQ bit was unchecked by oka@chromium.org

[oka, 2017-02-24 05:49:44]

The CQ bit was checked by oka@chromium.org

[commit-bot: I haz the power, 2017-02-24 05:49:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 06:06:10]

CQ is committing da patch.

Bot data: {"patchset_id": 90001, "attempt_start_ts": 1487915384043760,
"parent_rev": "bf45258a17f7f528b652a6b033c606787f8f9a0d", "commit_rev":
"f9c3dc95e104c9b8284652b05e649cc17a14cd1c"}

[commit-bot: I haz the power, 2017-02-24 06:07:45]

Description was changed from

==========
Compile more Gallery targets in gyp v2.

BUG=636289
TEST=run_compiler. Manually confirmed Gallery show images as before.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile more Gallery targets in gyp v2.

BUG=636289
TEST=run_compiler. Manually confirmed Gallery show images as before.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2702403008
Cr-Commit-Position: refs/heads/master@{#452769}
Committed:
https://chromium.googlesource.com/chromium/src/+/f9c3dc95e104c9b8284652b05e64...
==========

[commit-bot: I haz the power, 2017-02-24 06:07:48]

Committed patchset #6 (id:90001) as
https://chromium.googlesource.com/chromium/src/+/f9c3dc95e104c9b8284652b05e64...