Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: ui/file_manager/gallery/js/dimmable_ui_controller.js

Issue 2702403008: Compile more Gallery targets in gyp v2. (Closed)
Patch Set: Added _ suffix to private constant and formatted. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/gallery/js/dimmable_ui_controller.js
diff --git a/ui/file_manager/gallery/js/dimmable_ui_controller.js b/ui/file_manager/gallery/js/dimmable_ui_controller.js
index 3837374826ca109b73e89de6622be869885bf168..6632d1d2367503952982ced7d3cda0b8c144d10e 100644
--- a/ui/file_manager/gallery/js/dimmable_ui_controller.js
+++ b/ui/file_manager/gallery/js/dimmable_ui_controller.js
@@ -31,12 +31,12 @@ function DimmableUIController(container) {
this.isCursorInTools_ = false;
/**
- * @private {Gallery.Mode|undefined}
+ * @private {GalleryMode|undefined}
*/
this.mode_ = undefined;
/**
- * @private {Gallery.SubMode|undefined}
+ * @private {GallerySubMode|undefined}
*/
this.subMode_ = undefined;
@@ -98,8 +98,8 @@ DimmableUIController.MIN_OPERATION_INTERVAL = 500; // ms
/**
* Returns true if this controller should be disabled.
- * @param {Gallery.Mode|undefined} mode
- * @param {Gallery.SubMode|undefined} subMode
+ * @param {GalleryMode|undefined} mode
+ * @param {GallerySubMode|undefined} subMode
* @param {boolean} loading
* @param {boolean} spokenFeedbackEnabled
* @param {boolean} renaming
@@ -107,19 +107,17 @@ DimmableUIController.MIN_OPERATION_INTERVAL = 500; // ms
*/
DimmableUIController.shouldBeDisabled = function(
mode, subMode, loading, spokenFeedbackEnabled, renaming) {
- return spokenFeedbackEnabled ||
- mode === undefined ||
- subMode === undefined ||
- mode === Gallery.Mode.THUMBNAIL ||
- (mode === Gallery.Mode.SLIDE && subMode === Gallery.SubMode.EDIT) ||
- (mode === Gallery.Mode.SLIDE && subMode === Gallery.SubMode.BROWSE &&
+ return spokenFeedbackEnabled || mode === undefined || subMode === undefined ||
+ mode === GalleryMode.THUMBNAIL ||
+ (mode === GalleryMode.SLIDE && subMode === GallerySubMode.EDIT) ||
+ (mode === GalleryMode.SLIDE && subMode === GallerySubMode.BROWSE &&
(loading || renaming));
};
/**
* Sets current mode of Gallery.
- * @param {Gallery.Mode} mode
- * @param {Gallery.SubMode} subMode
+ * @param {GalleryMode} mode
+ * @param {GallerySubMode} subMode
*/
DimmableUIController.prototype.setCurrentMode = function(mode, subMode) {
if (this.mode_ === mode && this.subMode_ === subMode)
« no previous file with comments | « ui/file_manager/gallery/js/compiled_resources2.gyp ('k') | ui/file_manager/gallery/js/dimmable_ui_controller_unittest.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698