Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: ui/file_manager/gallery/js/compiled_resources2.gyp

Issue 2702403008: Compile more Gallery targets in gyp v2. (Closed)
Patch Set: Added _ suffix to private constant and formatted. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 # TODO(oka): Compile all the targets. 4 # TODO(oka): Compile all the targets.
5 { 5 {
6 'targets': [ 6 'targets': [
7 # { 7 # {
8 # 'target_name': 'background', 8 # 'target_name': 'background',
9 # 'includes': ['../../compile_js2.gypi'], 9 # 'includes': ['../../compile_js2.gypi'],
10 # }, 10 # },
11 # { 11 {
12 # 'target_name': 'dimmable_ui_controller', 12 'target_name': 'dimmable_ui_controller',
13 # 'includes': ['../../compile_js2.gypi'], 13 'dependencies': [
14 # }, 14 '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:assert',
15 # { 15 '<(EXTERNS_GYP):chrome_extensions',
16 # 'target_name': 'entry_list_watcher', 16 'gallery_constants',
17 # 'includes': ['../../compile_js2.gypi'], 17 ],
18 # }, 18 'includes': ['../../compile_js2.gypi'],
19 },
20 {
21 'target_name': 'entry_list_watcher',
22 'dependencies': [
23 '../../externs/compiled_resources2.gyp:platform',
24 '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:assert',
25 '<(DEPTH)/ui/webui/resources/js/cr/ui/compiled_resources2.gyp:array_data _model',
26 '<(EXTERNS_GYP):file_manager_private',
27 ],
28 'includes': ['../../compile_js2.gypi'],
29 },
19 { 30 {
20 'target_name': 'error_banner', 31 'target_name': 'error_banner',
21 'dependencies': [ 32 'dependencies': [
22 '../../file_manager/common/js/compiled_resources2.gyp:util', 33 '../../file_manager/common/js/compiled_resources2.gyp:util',
23 ], 34 ],
24 'includes': ['../../compile_js2.gypi'], 35 'includes': ['../../compile_js2.gypi'],
25 }, 36 },
26 # { 37 # {
27 # 'target_name': 'gallery', 38 # 'target_name': 'gallery',
28 # 'includes': ['../../compile_js2.gypi'], 39 # 'includes': ['../../compile_js2.gypi'],
29 # }, 40 # },
41 {
42 'target_name': 'gallery_constants',
43 'includes': ['../../compile_js2.gypi'],
44 },
30 # { 45 # {
31 # 'target_name': 'gallery_data_model', 46 # 'target_name': 'gallery_data_model',
32 # 'dependencies': [ 47 # 'dependencies': [
33 # 'thumbnail_mode', 48 # 'thumbnail_mode',
34 # '../../file_manager/common/js/compiled_resources2.gyp:util', 49 # '../../file_manager/common/js/compiled_resources2.gyp:util',
35 # '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:assert', 50 # '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:assert',
36 # 'gallery_item', 51 # 'gallery_item',
37 # '<(DEPTH)/ui/webui/resources/js/cr/ui/compiled_resources2.gyp:array_dat a_model', 52 # '<(DEPTH)/ui/webui/resources/js/cr/ui/compiled_resources2.gyp:array_dat a_model',
38 # ], 53 # ],
39 # 'includes': ['../../compile_js2.gypi'], 54 # 'includes': ['../../compile_js2.gypi'],
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 # '<(DEPTH)/ui/webui/resources/js/cr/ui/compiled_resources2.gyp:list_sele ction_model', 119 # '<(DEPTH)/ui/webui/resources/js/cr/ui/compiled_resources2.gyp:list_sele ction_model',
105 # 'error_banner', 120 # 'error_banner',
106 # 'gallery_data_model', 121 # 'gallery_data_model',
107 # 'gallery_item', 122 # 'gallery_item',
108 # 'image_editor/compiled_resources2.gyp:image_editor', 123 # 'image_editor/compiled_resources2.gyp:image_editor',
109 # ], 124 # ],
110 # 'includes': ['../../compile_js2.gypi'], 125 # 'includes': ['../../compile_js2.gypi'],
111 # }, 126 # },
112 ], 127 ],
113 } 128 }
OLDNEW
« no previous file with comments | « ui/file_manager/gallery/js/compiled_resources.gyp ('k') | ui/file_manager/gallery/js/dimmable_ui_controller.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698