Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: ui/file_manager/gallery/js/gallery.js

Issue 2702403008: Compile more Gallery targets in gyp v2. (Closed)
Patch Set: Added _ suffix to private constant and formatted. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/gallery/js/gallery.js
diff --git a/ui/file_manager/gallery/js/gallery.js b/ui/file_manager/gallery/js/gallery.js
index 71aaac3f29b6d6f0f97e38adffc690418a099a4f..cd07d9a3b388781aad9f37e6ddb356ebd6410d54 100644
--- a/ui/file_manager/gallery/js/gallery.js
+++ b/ui/file_manager/gallery/js/gallery.js
@@ -229,38 +229,18 @@ function Gallery(volumeManager) {
/**
* First time tools fade-out timeout in milliseconds.
- * @const
- * @type {number}
+ * @const {number}
+ * @private
*/
-Gallery.FIRST_FADE_TIMEOUT = 1000;
+Gallery.FIRST_FADE_TIMEOUT_ = 1000;
/**
* Time until mosaic is initialized in the background. Used to make gallery
* in the slide mode load faster. In milliseconds.
- * @const
- * @type {number}
- */
-Gallery.MOSAIC_BACKGROUND_INIT_DELAY = 1000;
-
-/**
- * Modes in Gallery.
- * @enum {string}
- */
-Gallery.Mode = {
- SLIDE: 'slide',
- THUMBNAIL: 'thumbnail'
-};
-
-/**
- * Sub modes in Gallery.
- * @enum {string}
- * TODO(yawano): Remove sub modes by extracting them as modes.
+ * @const {number}
+ * @private
*/
-Gallery.SubMode = {
- BROWSE: 'browse',
- EDIT: 'edit',
- SLIDESHOW: 'slideshow'
-};
+Gallery.MOSAIC_BACKGROUND_INIT_DELAY_ = 1000;
/**
* Updates attributes of container element when accessibility configuration has
@@ -416,7 +396,7 @@ Gallery.prototype.loadInternal_ = function(entries, selectedEntries) {
null,
function() {
// Flash the toolbar briefly to show it is there.
- self.dimmableUIController_.kick(Gallery.FIRST_FADE_TIMEOUT);
+ self.dimmableUIController_.kick(Gallery.FIRST_FADE_TIMEOUT_);
},
function() {});
}
@@ -446,14 +426,14 @@ Gallery.prototype.onUserAction_ = function() {
/**
* Returns the current mode.
- * @return {Gallery.Mode}
+ * @return {GalleryMode}
*/
Gallery.prototype.getCurrentMode = function() {
switch (/** @type {(SlideMode|ThumbnailMode)} */ (this.currentMode_)) {
case this.slideMode_:
- return Gallery.Mode.SLIDE;
+ return GalleryMode.SLIDE;
case this.thumbnailMode_:
- return Gallery.Mode.THUMBNAIL;
+ return GalleryMode.THUMBNAIL;
default:
assertNotReached();
}
@@ -462,7 +442,7 @@ Gallery.prototype.getCurrentMode = function() {
/**
* Returns sub mode of current mode. If current mode is not set yet, null is
* returned.
- * @return {Gallery.SubMode}
+ * @return {GallerySubMode}
*/
Gallery.prototype.getCurrentSubMode = function() {
assert(this.currentMode_);
@@ -935,14 +915,16 @@ Gallery.prototype.onFilenameEditBlur_ = function(event) {
/**
* Minimum width of rename field.
* @const {number}
+ * @private
*/
-Gallery.MIN_WIDTH_RENAME_FIELD = 160; // px
+Gallery.MIN_WIDTH_RENAME_FIELD_ = 160; // px
/**
* End padding for rename field.
* @const {number}
+ * @private
*/
-Gallery.END_PADDING_RENAME_FIELD = 20; // px
+Gallery.END_PADDING_RENAME_FIELD_ = 20; // px
/**
* Resize rename field depending on its content.
@@ -951,9 +933,11 @@ Gallery.END_PADDING_RENAME_FIELD = 20; // px
Gallery.prototype.resizeRenameField_ = function() {
var size = this.filenameCanvasContext_.measureText(this.filenameEdit_.value);
- var width = Math.min(Math.max(
- size.width + Gallery.END_PADDING_RENAME_FIELD,
- Gallery.MIN_WIDTH_RENAME_FIELD), window.innerWidth / 2);
+ var width = Math.min(
+ Math.max(
+ size.width + Gallery.END_PADDING_RENAME_FIELD_,
+ Gallery.MIN_WIDTH_RENAME_FIELD_),
+ window.innerWidth / 2);
this.filenameEdit_.style.width = width + 'px';
};
« no previous file with comments | « ui/file_manager/gallery/js/dimmable_ui_controller_unittest.js ('k') | ui/file_manager/gallery/js/gallery_constants.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698