Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: ui/file_manager/gallery/js/compiled_resources2.gyp

Issue 2702403008: Compile more Gallery targets in gyp v2. (Closed)
Patch Set: Added _ suffix to private constant and formatted. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/gallery/js/compiled_resources2.gyp
diff --git a/ui/file_manager/gallery/js/compiled_resources2.gyp b/ui/file_manager/gallery/js/compiled_resources2.gyp
index 1f7eb261ea9610fec6049d44ce810f114c22192e..ec96d1b91bfa46af5ac4ed52f678d3dbb400e0df 100644
--- a/ui/file_manager/gallery/js/compiled_resources2.gyp
+++ b/ui/file_manager/gallery/js/compiled_resources2.gyp
@@ -8,14 +8,25 @@
# 'target_name': 'background',
# 'includes': ['../../compile_js2.gypi'],
# },
-# {
-# 'target_name': 'dimmable_ui_controller',
-# 'includes': ['../../compile_js2.gypi'],
-# },
-# {
-# 'target_name': 'entry_list_watcher',
-# 'includes': ['../../compile_js2.gypi'],
-# },
+ {
+ 'target_name': 'dimmable_ui_controller',
+ 'dependencies': [
+ '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:assert',
+ '<(EXTERNS_GYP):chrome_extensions',
+ 'gallery_constants',
+ ],
+ 'includes': ['../../compile_js2.gypi'],
+ },
+ {
+ 'target_name': 'entry_list_watcher',
+ 'dependencies': [
+ '../../externs/compiled_resources2.gyp:platform',
+ '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:assert',
+ '<(DEPTH)/ui/webui/resources/js/cr/ui/compiled_resources2.gyp:array_data_model',
+ '<(EXTERNS_GYP):file_manager_private',
+ ],
+ 'includes': ['../../compile_js2.gypi'],
+ },
{
'target_name': 'error_banner',
'dependencies': [
@@ -27,6 +38,10 @@
# 'target_name': 'gallery',
# 'includes': ['../../compile_js2.gypi'],
# },
+ {
+ 'target_name': 'gallery_constants',
+ 'includes': ['../../compile_js2.gypi'],
+ },
# {
# 'target_name': 'gallery_data_model',
# 'dependencies': [
« no previous file with comments | « ui/file_manager/gallery/js/compiled_resources.gyp ('k') | ui/file_manager/gallery/js/dimmable_ui_controller.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698