ui/file_manager/gallery/js/dimmable_ui_controller_unittest.js - Issue 2702403008: Compile more Gallery targets in gyp v2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/gallery/js/dimmable_ui_controller_unittest.js

Issue 2702403008: Compile more Gallery targets in gyp v2. (Closed)

Patch Set: Added _ suffix to private constant and formatted. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/file_manager/gallery/js/dimmable_ui_controller_unittest.js

diff --git a/ui/file_manager/gallery/js/dimmable_ui_controller_unittest.js b/ui/file_manager/gallery/js/dimmable_ui_controller_unittest.js

index c695f7a2c4dac8afda27fce3f7e56277a4fae1e6..1040026d19eca5352162fad237e9d1651560e7ab 100644

--- a/ui/file_manager/gallery/js/dimmable_ui_controller_unittest.js

+++ b/ui/file_manager/gallery/js/dimmable_ui_controller_unittest.js

@@ -10,31 +10,31 @@ function testShouldBeDisabled() {

// Disabled in thumbnail mode.

assertTrue(DimmableUIController.shouldBeDisabled(

- Gallery.Mode.THUMBNAIL, Gallery.SubMode.BROWSE, false /* loading */,

+ GalleryMode.THUMBNAIL, GallerySubMode.BROWSE, false /* loading */,

false /* spokenFeedbackEnabled */, false /* renaming */));

// Disabled in edit mode.

assertTrue(DimmableUIController.shouldBeDisabled(

- Gallery.Mode.SLIDE, Gallery.SubMode.EDIT, false /* loading*/,

+ GalleryMode.SLIDE, GallerySubMode.EDIT, false /* loading*/,

false /* spokenFeedbackEnabled */, false /* renaming */));

// Shouldn't be disabled while browsing in slide mode.

assertFalse(DimmableUIController.shouldBeDisabled(

- Gallery.Mode.SLIDE, Gallery.SubMode.BROWSE, false /* loading */,

+ GalleryMode.SLIDE, GallerySubMode.BROWSE, false /* loading */,

false /* spokenFeedbackEnabled */, false /* renaming */));

// Disabled while loading an image in slide mode.

assertTrue(DimmableUIController.shouldBeDisabled(

- Gallery.Mode.SLIDE, Gallery.SubMode.BROWSE, true /* loading */,

+ GalleryMode.SLIDE, GallerySubMode.BROWSE, true /* loading */,

false /* spokenFeedbackEnabled */, false /* renaming */));

// Disabled when spoken feedback is enabled.

assertTrue(DimmableUIController.shouldBeDisabled(

- Gallery.Mode.SLIDE, Gallery.SubMode.BROWSE, false /* loading */,

+ GalleryMode.SLIDE, GallerySubMode.BROWSE, false /* loading */,

true /* spokenFeedbackEnabled */, false /* renaming */));

// Disabled when user is renaming an image.

assertTrue(DimmableUIController.shouldBeDisabled(

- Gallery.Mode.SLIDE, Gallery.SubMode.BROWSE, false /* loading */,

+ GalleryMode.SLIDE, GallerySubMode.BROWSE, false /* loading */,

false /* spokenFeedbackEnabled */, true /* renaming */))

}