Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2702403003: [layoutng] Split NGLayoutResult out of NGPhysicalFragment (Closed)

Created:
3 years, 10 months ago by cbiesinger
Modified:
3 years, 10 months ago
Reviewers:
ikilpatrick, eae
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Split NGLayoutResult out of NGPhysicalFragment R=ikilpatrick@chromium.org,eae@chromium.org BUG=635619 Review-Url: https://codereview.chromium.org/2702403003 Cr-Commit-Position: refs/heads/master@{#452299} Committed: https://chromium.googlesource.com/chromium/src/+/2ad35b86c33fe62c3be7c9368a009716d9892324

Patch Set 1 #

Total comments: 17

Patch Set 2 : slight cleanup #

Total comments: 3

Patch Set 3 : review comments #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -195 lines) Patch
M third_party/WebKit/Source/core/layout/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 2 3 4 chunks +17 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.h View 1 2 3 5 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 1 2 3 9 chunks +31 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc View 1 2 3 5 chunks +19 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_input_node.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_layout_result.h View 1 2 1 chunk +73 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_layout_result.cc View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.h View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc View 1 2 6 chunks +12 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h View 4 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h View 1 2 3 4 chunks +3 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.cc View 1 chunk +6 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h View 1 chunk +8 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/NGInlineLayoutTest.cpp View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
cbiesinger
3 years, 10 months ago (2017-02-21 22:16:21 UTC) #1
ikilpatrick
https://codereview.chromium.org/2702403003/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_node.h File third_party/WebKit/Source/core/layout/ng/ng_block_node.h (right): https://codereview.chromium.org/2702403003/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_node.h#newcode56 third_party/WebKit/Source/core/layout/ng/ng_block_node.h:56: /// void SetFragment(NGPhysicalBoxFragment* fragment) { fragment_ = fragment; remove ...
3 years, 10 months ago (2017-02-21 22:26:03 UTC) #6
eae
https://codereview.chromium.org/2702403003/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_layout_result.h File third_party/WebKit/Source/core/layout/ng/ng_layout_result.h (right): https://codereview.chromium.org/2702403003/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_layout_result.h#newcode22 third_party/WebKit/Source/core/layout/ng/ng_layout_result.h:22: // The NGLayoutResult stores the resulting data from layout. ...
3 years, 10 months ago (2017-02-21 22:39:05 UTC) #9
ikilpatrick
https://codereview.chromium.org/2702403003/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_layout_result.h File third_party/WebKit/Source/core/layout/ng/ng_layout_result.h (right): https://codereview.chromium.org/2702403003/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_layout_result.h#newcode22 third_party/WebKit/Source/core/layout/ng/ng_layout_result.h:22: // The NGLayoutResult stores the resulting data from layout. ...
3 years, 10 months ago (2017-02-21 22:48:56 UTC) #10
eae
On 2017/02/21 22:48:56, ikilpatrick wrote: > https://codereview.chromium.org/2702403003/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_layout_result.h > File third_party/WebKit/Source/core/layout/ng/ng_layout_result.h (right): > > https://codereview.chromium.org/2702403003/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_layout_result.h#newcode22 > ...
3 years, 10 months ago (2017-02-21 23:00:36 UTC) #11
cbiesinger
I prefer result over context, because to me "context" sounds like an input, not an ...
3 years, 10 months ago (2017-02-22 18:09:01 UTC) #12
ikilpatrick
lgtm re: bfcoffset/marginstrut - sgtm, might be better to return a LayoutResult from the helper ...
3 years, 10 months ago (2017-02-22 18:52:27 UTC) #13
eae
LGTM
3 years, 10 months ago (2017-02-22 22:17:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702403003/60001
3 years, 10 months ago (2017-02-22 22:23:55 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 00:20:15 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2ad35b86c33fe62c3be7c9368a00...

Powered by Google App Engine
This is Rietveld 408576698