Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h

Issue 2702403003: [layoutng] Split NGLayoutResult out of NGPhysicalFragment (Closed)
Patch Set: rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h b/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h
index 53269660274eee2a0ae9698f356ab2e2e2bc831e..1a259c1a4eb918908490d737671f6e20b02007d0 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h
@@ -13,7 +13,6 @@
namespace blink {
-class NGBlockNode;
struct NGFloatingObject;
class CORE_EXPORT NGPhysicalBoxFragment final : public NGPhysicalFragment {
@@ -24,10 +23,6 @@ class CORE_EXPORT NGPhysicalBoxFragment final : public NGPhysicalFragment {
NGPhysicalSize size,
NGPhysicalSize overflow,
Vector<RefPtr<NGPhysicalFragment>>& children,
- PersistentHeapLinkedHashSet<WeakMember<NGBlockNode>>&
- out_of_flow_descendants,
- Vector<NGStaticPosition>& out_of_flow_positions,
- Vector<Persistent<NGFloatingObject>>& unpositioned_floats,
Vector<Persistent<NGFloatingObject>>& positioned_floats,
const WTF::Optional<NGLogicalOffset>& bfc_offset,
const NGMarginStrut& end_margin_strut,
@@ -37,6 +32,13 @@ class CORE_EXPORT NGPhysicalBoxFragment final : public NGPhysicalFragment {
return children_;
}
+ // List of positioned float that need to be copied to the old layout tree.
+ // TODO(layout-ng): remove this once we change painting code to handle floats
+ // differently.
+ const Vector<Persistent<NGFloatingObject>>& PositionedFloats() const {
+ return positioned_floats_;
+ }
+
const WTF::Optional<NGLogicalOffset>& BfcOffset() const {
return bfc_offset_;
}
@@ -45,6 +47,7 @@ class CORE_EXPORT NGPhysicalBoxFragment final : public NGPhysicalFragment {
private:
Vector<RefPtr<NGPhysicalFragment>> children_;
+ Vector<Persistent<NGFloatingObject>> positioned_floats_;
const WTF::Optional<NGLogicalOffset> bfc_offset_;
const NGMarginStrut end_margin_strut_;
};

Powered by Google App Engine
This is Rietveld 408576698