Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc

Issue 2702403003: [layoutng] Split NGLayoutResult out of NGPhysicalFragment (Closed)
Patch Set: rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc b/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc
index ad9d2fcd235cea46b55a38c9c898c6987e8b5677..04d247bf3281667690c112ac0e96ca7e384183e1 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc
@@ -4,6 +4,8 @@
#include "core/layout/ng/ng_physical_box_fragment.h"
+#include "core/layout/ng/ng_floating_object.h"
+
namespace blink {
NGPhysicalBoxFragment::NGPhysicalBoxFragment(
@@ -11,10 +13,6 @@ NGPhysicalBoxFragment::NGPhysicalBoxFragment(
NGPhysicalSize size,
NGPhysicalSize overflow,
Vector<RefPtr<NGPhysicalFragment>>& children,
- PersistentHeapLinkedHashSet<WeakMember<NGBlockNode>>&
- out_of_flow_descendants,
- Vector<NGStaticPosition>& out_of_flow_positions,
- Vector<Persistent<NGFloatingObject>>& unpositioned_floats,
Vector<Persistent<NGFloatingObject>>& positioned_floats,
const WTF::Optional<NGLogicalOffset>& bfc_offset,
const NGMarginStrut& end_margin_strut,
@@ -23,11 +21,8 @@ NGPhysicalBoxFragment::NGPhysicalBoxFragment(
size,
overflow,
kFragmentBox,
- out_of_flow_descendants,
- out_of_flow_positions,
- unpositioned_floats,
- positioned_floats,
break_token),
+ positioned_floats_(positioned_floats),
bfc_offset_(bfc_offset),
end_margin_strut_(end_margin_strut) {
children_.swap(children);

Powered by Google App Engine
This is Rietveld 408576698