third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.h - Issue 2702403003: [layoutng] Split NGLayoutResult out of NGPhysicalFragment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.h

Issue 2702403003: [layoutng] Split NGLayoutResult out of NGPhysicalFragment (Closed)

Patch Set: rebased Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_layout_result.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.h b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.h

index daf91ef2a6c13c36c211dadb219a42606b7e806f..284f7b340297a20cc29a4f474cbe0f97dd96144e 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.h

@@ -20,6 +20,7 @@ class ComputedStyle;

class NGBlockNode;

class NGFragmentBuilder;

class NGConstraintSpace;

+class NGLayoutResult;

// Helper class for positioning of out-of-flow blocks.

// It should be used together with NGFragmentBuilder.

@@ -34,11 +35,11 @@ class CORE_EXPORT NGOutOfFlowLayoutPart {

void Run();

private:

- RefPtr<NGPhysicalFragment> LayoutDescendant(NGBlockNode& descendant,

- NGStaticPosition static_position,

- NGLogicalOffset* offset);

+ RefPtr<NGLayoutResult> LayoutDescendant(NGBlockNode& descendant,

+ NGStaticPosition static_position,

+ NGLogicalOffset* offset);

- RefPtr<NGPhysicalFragment> GenerateFragment(

+ RefPtr<NGLayoutResult> GenerateFragment(

NGBlockNode& node,

const Optional<LayoutUnit>& block_estimate,

const NGAbsolutePhysicalPosition node_position);