Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2697603006: DevTools: Fix an exception on adding watch expression. (Closed)

Created:
3 years, 10 months ago by tkent
Modified:
3 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
aboxhall, aboxhall+watch_chromium.org, apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dmazzoni, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, nektarios, nektar+watch_chromium.org, pfeldman+blink_chromium.org, pfeldman, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Fix an exception on adding watch expression. Also, fix all of suspicious usage of Selection.setBaseAndExtent() in DevTools. BUG=691926 Review-Url: https://codereview.chromium.org/2697603006 Cr-Commit-Position: refs/heads/master@{#450573} Committed: https://chromium.googlesource.com/chromium/src/+/f3e70ddf82a6c476f094c9d9c641041135b40171

Patch Set 1 #

Messages

Total messages: 14 (9 generated)
tkent
yosin@, would you review this please? I have no idea how to test this.
3 years, 10 months ago (2017-02-15 01:41:44 UTC) #7
yosin_UTC9
lgtm Could you file a bug or use 691926 to ask DevTool team to write ...
3 years, 10 months ago (2017-02-15 01:51:30 UTC) #8
tkent
On 2017/02/15 at 01:51:30, yosin wrote: > Could you file a bug or use 691926 ...
3 years, 10 months ago (2017-02-15 02:26:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697603006/1
3 years, 10 months ago (2017-02-15 02:28:06 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 05:55:31 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f3e70ddf82a6c476f094c9d9c641...

Powered by Google App Engine
This is Rietveld 408576698