third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js - Issue 2697603006: DevTools: Fix an exception on adding watch expression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js

Issue 2697603006: DevTools: Fix an exception on adding watch expression. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js

diff --git a/third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js b/third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js

index f9adfccc669d1785cf6c5cde6bcc19707e279576..d4eb621ab5a90e8847f9ddc53999a043d7e4a9a8 100644

--- a/third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js

+++ b/third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js

@@ -306,7 +306,7 @@ DataGrid.DataGrid = class extends Common.Object {

var element = this._editingNode._element.children[cellIndex];

UI.InplaceEditor.startEditing(element, this._startEditingConfig(element));

- element.getComponentSelection().setBaseAndExtent(element, 0, element, 1);

+ element.getComponentSelection().selectAllChildren(element);

}

/**

@@ -345,7 +345,7 @@ DataGrid.DataGrid = class extends Common.Object {

this._editing = true;

UI.InplaceEditor.startEditing(element, this._startEditingConfig(element));

- element.getComponentSelection().setBaseAndExtent(element, 0, element, 1);

+ element.getComponentSelection().selectAllChildren(element);

}

renderInline() {