third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js - Issue 2697603006: DevTools: Fix an exception on adding watch expression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

Issue 2697603006: DevTools: Fix an exception on adding watch expression. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/accessibility/ARIAAttributesView.js ('k') | third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js b/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

index 1930fe950c7f07e2aa4542d18acbc5a0c7f157d9..91f67a47c6cd40341bae7509d2b94f81937180a8 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

@@ -835,7 +835,7 @@ Components.ObjectPropertyTreeElement = class extends UI.TreeElement {

var proxyElement =

this._prompt.attachAndStartEditing(this._editableDiv, this._editingCommitted.bind(this, originalContent));

- this.listItemElement.getComponentSelection().setBaseAndExtent(this._editableDiv, 0, this._editableDiv, 1);

+ this.listItemElement.getComponentSelection().selectAllChildren(this._editableDiv);

proxyElement.addEventListener('keydown', this._promptKeyDown.bind(this, originalContent), false);

}