third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js - Issue 2697603006: DevTools: Fix an exception on adding watch expression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

Issue 2697603006: DevTools: Fix an exception on adding watch expression. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

index c44b87afe5df574448d4df7688f2eb619160cabd..b370c306e56d354bb79ee383c18a20447d08ffa6 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

@@ -639,7 +639,7 @@ Elements.ElementsTreeElement = class extends UI.TreeElement {

this._editing = UI.InplaceEditor.startEditing(attribute, config);

- this.listItemElement.getComponentSelection().setBaseAndExtent(elementForSelection, 0, elementForSelection, 1);

+ this.listItemElement.getComponentSelection().selectAllChildren(elementForSelection);

return true;

}

@@ -663,7 +663,7 @@ Elements.ElementsTreeElement = class extends UI.TreeElement {

var config = new UI.InplaceEditor.Config(

this._textNodeEditingCommitted.bind(this, textNode), this._editingCancelled.bind(this));

this._editing = UI.InplaceEditor.startEditing(textNodeElement, config);

- this.listItemElement.getComponentSelection().setBaseAndExtent(textNodeElement, 0, textNodeElement, 1);

+ this.listItemElement.getComponentSelection().selectAllChildren(textNodeElement);

return true;

}

@@ -717,7 +717,7 @@ Elements.ElementsTreeElement = class extends UI.TreeElement {

var config = new UI.InplaceEditor.Config(editingComitted.bind(this), editingCancelled.bind(this), tagName);

this._editing = UI.InplaceEditor.startEditing(tagNameElement, config);

- this.listItemElement.getComponentSelection().setBaseAndExtent(tagNameElement, 0, tagNameElement, 1);

+ this.listItemElement.getComponentSelection().selectAllChildren(tagNameElement);

return true;

}