third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js - Issue 2697603006: DevTools: Fix an exception on adding watch expression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

Issue 2697603006: DevTools: Fix an exception on adding watch expression. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

index 2a612ed08955cba93de5690ba0a6c511fc4dcb9c..b4ffe1dc32a7e4c7218ed90266c4f3c119e1e02d 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

@@ -1286,7 +1286,7 @@ Elements.StylePropertiesSection = class {

this._editingMediaBlurHandler.bind(this));

UI.InplaceEditor.startEditing(element, config);

- element.getComponentSelection().setBaseAndExtent(element, 0, element, 1);

+ element.getComponentSelection().selectAllChildren(element);

this._parentPane.setEditingStyle(true);

var parentMediaElement = element.enclosingNodeOrSelfWithClass('media');

parentMediaElement.classList.add('editing-media');

@@ -1417,7 +1417,7 @@ Elements.StylePropertiesSection = class {

new UI.InplaceEditor.Config(this.editingSelectorCommitted.bind(this), this.editingSelectorCancelled.bind(this));

UI.InplaceEditor.startEditing(this._selectorElement, config);

- element.getComponentSelection().setBaseAndExtent(element, 0, element, 1);

+ element.getComponentSelection().selectAllChildren(element);

this._parentPane.setEditingStyle(true);

if (element.classList.contains('simple-selector'))

this._navigateToSelectorSource(0, false);

@@ -2369,8 +2369,7 @@ Elements.StylePropertyTreeElement = class extends UI.TreeElement {

if (isEditingName)

proxyElement.addEventListener('paste', pasteHandler.bind(this, context), false);

- selectElement.getComponentSelection().setBaseAndExtent(

- selectElement, 0, selectElement, selectElement.firstChild ? 1 : 0);

+ selectElement.getComponentSelection().selectAllChildren(selectElement);

}

/**