third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js - Issue 2697603006: DevTools: Fix an exception on adding watch expression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

Issue 2697603006: DevTools: Fix an exception on adding watch expression. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

index 4982a85afa18c9d13b83a0742f6f114ad6f02b36..5f0db5386135f03a5381a6f241f0c29a58b46637 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

@@ -260,7 +260,7 @@ Sources.WatchExpression = class extends Common.Object {

var proxyElement = this._textPrompt.attachAndStartEditing(newDiv, this._finishEditing.bind(this));

proxyElement.classList.add('watch-expression-text-prompt-proxy');

proxyElement.addEventListener('keydown', this._promptKeyDown.bind(this), false);

- this._element.getComponentSelection().setBaseAndExtent(newDiv, 0, newDiv, 1);

+ this._element.getComponentSelection().selectAllChildren(newDiv);

}

/**