Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 2697513007: Windows CrashReporterClient cleanups in the wake of InstallDetails everywhere. (Closed)

Created:
3 years, 10 months ago by grt (UTC plus 2)
Modified:
3 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews, sadrul, grt+watch_chromium.org, jam, pennymac+watch_chromium.org, darin-cc_chromium.org, wfh+watch_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Windows CrashReporterClient cleanups in the wake of InstallDetails everywhere. - GetIsPerUserInstall no longer needs to know the path to the exe. - GetShouldDumpLargerDumps no longer needs to know the install level. BUG=373987 R=scottmg@chromium.org Review-Url: https://codereview.chromium.org/2697513007 Cr-Commit-Position: refs/heads/master@{#452943} Committed: https://chromium.googlesource.com/chromium/src/+/4e8c7bbcbe48fc7f786b3541ad43362b96d56a35

Patch Set 1 #

Patch Set 2 : sync to position 452911 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -31 lines) Patch
M chrome/app/chrome_crash_reporter_client_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client_win.cc View 1 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/installer/setup/installer_crash_reporter_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/installer_crash_reporter_client.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M components/crash/content/app/breakpad_win.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M components/crash/content/app/crash_keys_win_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/crash/content/app/crash_reporter_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/crash/content/app/crash_reporter_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/crash/content/app/crashpad_win.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
grt (UTC plus 2)
PTAL
3 years, 10 months ago (2017-02-15 09:44:53 UTC) #3
scottmg
nice, lgtm
3 years, 10 months ago (2017-02-15 17:43:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697513007/20001
3 years, 10 months ago (2017-02-24 20:35:12 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 22:06:28 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4e8c7bbcbe48fc7f786b3541ad43...

Powered by Google App Engine
This is Rietveld 408576698