Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1566)

Side by Side Diff: chrome/installer/setup/installer_crash_reporter_client.cc

Issue 2697513007: Windows CrashReporterClient cleanups in the wake of InstallDetails everywhere. (Closed)
Patch Set: sync to position 452911 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/installer/setup/installer_crash_reporter_client.h" 5 #include "chrome/installer/setup/installer_crash_reporter_client.h"
6 6
7 #include "base/debug/crash_logging.h" 7 #include "base/debug/crash_logging.h"
8 #include "base/environment.h" 8 #include "base/environment.h"
9 #include "base/file_version_info.h" 9 #include "base/file_version_info.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 // The installer should never be restarted after a crash. 70 // The installer should never be restarted after a crash.
71 return false; 71 return false;
72 } 72 }
73 73
74 bool InstallerCrashReporterClient::GetDeferredUploadsSupported( 74 bool InstallerCrashReporterClient::GetDeferredUploadsSupported(
75 bool is_per_user_install) { 75 bool is_per_user_install) {
76 // Copy Chrome's impl? 76 // Copy Chrome's impl?
77 return false; 77 return false;
78 } 78 }
79 79
80 bool InstallerCrashReporterClient::GetIsPerUserInstall( 80 bool InstallerCrashReporterClient::GetIsPerUserInstall() {
81 const base::string16& exe_path) {
82 return is_per_user_install_; 81 return is_per_user_install_;
83 } 82 }
84 83
85 bool InstallerCrashReporterClient::GetShouldDumpLargerDumps( 84 bool InstallerCrashReporterClient::GetShouldDumpLargerDumps() {
86 bool is_per_user_install) {
87 DCHECK_EQ(is_per_user_install_, is_per_user_install);
88 // Use large dumps for all but the stable channel. 85 // Use large dumps for all but the stable channel.
89 return !install_static::GetChromeChannelName().empty(); 86 return !install_static::GetChromeChannelName().empty();
90 } 87 }
91 88
92 int InstallerCrashReporterClient::GetResultCodeRespawnFailed() { 89 int InstallerCrashReporterClient::GetResultCodeRespawnFailed() {
93 // The restart dialog is never shown for the installer. 90 // The restart dialog is never shown for the installer.
94 NOTREACHED(); 91 NOTREACHED();
95 return 0; 92 return 0;
96 } 93 }
97 94
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 } 163 }
167 } 164 }
168 165
169 return false; 166 return false;
170 } 167 }
171 168
172 bool InstallerCrashReporterClient::EnableBreakpadForProcess( 169 bool InstallerCrashReporterClient::EnableBreakpadForProcess(
173 const std::string& process_type) { 170 const std::string& process_type) {
174 return true; 171 return true;
175 } 172 }
OLDNEW
« no previous file with comments | « chrome/installer/setup/installer_crash_reporter_client.h ('k') | components/crash/content/app/breakpad_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698