Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1738)

Unified Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 2697513007: Windows CrashReporterClient cleanups in the wake of InstallDetails everywhere. (Closed)
Patch Set: sync to position 452911 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/chrome_crash_reporter_client_win.cc
diff --git a/chrome/app/chrome_crash_reporter_client_win.cc b/chrome/app/chrome_crash_reporter_client_win.cc
index 39693f36c0f060cfb4bf25fefb3e5535abae9b0b..0ee2f24a0e7fcedbaf8508dbbba50240debf9810 100644
--- a/chrome/app/chrome_crash_reporter_client_win.cc
+++ b/chrome/app/chrome_crash_reporter_client_win.cc
@@ -324,16 +324,11 @@ bool ChromeCrashReporterClient::GetDeferredUploadsSupported(
return false;
}
-// TODO(grt): Remove |exe_path| from crash_reporter::CrashReporterClient.
-bool ChromeCrashReporterClient::GetIsPerUserInstall(
- const base::string16& exe_path) {
+bool ChromeCrashReporterClient::GetIsPerUserInstall() {
return !install_static::InstallDetails::Get().system_level();
}
-// TODO(grt): Remove |is_per_user_install| from
-// crash_reporter::CrashReporterClient.
-bool ChromeCrashReporterClient::GetShouldDumpLargerDumps(
- bool is_per_user_install) {
+bool ChromeCrashReporterClient::GetShouldDumpLargerDumps() {
// Capture larger dumps for Google Chrome "beta", "dev", and "canary"
// channels. Stable channel and Chromium builds are on channel "", and use
// smaller dumps.
« no previous file with comments | « chrome/app/chrome_crash_reporter_client_win.h ('k') | chrome/installer/setup/installer_crash_reporter_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698