Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 2697513007: Windows CrashReporterClient cleanups in the wake of InstallDetails everywhere. (Closed)
Patch Set: sync to position 452911 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(ananta/scottmg) 5 // TODO(ananta/scottmg)
6 // Add test coverage for Crashpad. 6 // Add test coverage for Crashpad.
7 #include "chrome/app/chrome_crash_reporter_client_win.h" 7 #include "chrome/app/chrome_crash_reporter_client_win.h"
8 8
9 #include <assert.h> 9 #include <assert.h>
10 #include <windows.h> 10 #include <windows.h>
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 317
318 install_static::SetEnvironmentString16(install_static::kShowRestart, L"1"); 318 install_static::SetEnvironmentString16(install_static::kShowRestart, L"1");
319 return true; 319 return true;
320 } 320 }
321 321
322 bool ChromeCrashReporterClient::GetDeferredUploadsSupported( 322 bool ChromeCrashReporterClient::GetDeferredUploadsSupported(
323 bool is_per_user_install) { 323 bool is_per_user_install) {
324 return false; 324 return false;
325 } 325 }
326 326
327 // TODO(grt): Remove |exe_path| from crash_reporter::CrashReporterClient. 327 bool ChromeCrashReporterClient::GetIsPerUserInstall() {
328 bool ChromeCrashReporterClient::GetIsPerUserInstall(
329 const base::string16& exe_path) {
330 return !install_static::InstallDetails::Get().system_level(); 328 return !install_static::InstallDetails::Get().system_level();
331 } 329 }
332 330
333 // TODO(grt): Remove |is_per_user_install| from 331 bool ChromeCrashReporterClient::GetShouldDumpLargerDumps() {
334 // crash_reporter::CrashReporterClient.
335 bool ChromeCrashReporterClient::GetShouldDumpLargerDumps(
336 bool is_per_user_install) {
337 // Capture larger dumps for Google Chrome "beta", "dev", and "canary" 332 // Capture larger dumps for Google Chrome "beta", "dev", and "canary"
338 // channels. Stable channel and Chromium builds are on channel "", and use 333 // channels. Stable channel and Chromium builds are on channel "", and use
339 // smaller dumps. 334 // smaller dumps.
340 return !install_static::InstallDetails::Get().channel().empty(); 335 return !install_static::InstallDetails::Get().channel().empty();
341 } 336 }
342 337
343 int ChromeCrashReporterClient::GetResultCodeRespawnFailed() { 338 int ChromeCrashReporterClient::GetResultCodeRespawnFailed() {
344 return chrome::RESULT_CODE_RESPAWN_FAILED; 339 return chrome::RESULT_CODE_RESPAWN_FAILED;
345 } 340 }
346 341
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
394 bool ChromeCrashReporterClient::GetCollectStatsInSample() { 389 bool ChromeCrashReporterClient::GetCollectStatsInSample() {
395 return install_static::GetCollectStatsInSample(); 390 return install_static::GetCollectStatsInSample();
396 } 391 }
397 392
398 bool ChromeCrashReporterClient::EnableBreakpadForProcess( 393 bool ChromeCrashReporterClient::EnableBreakpadForProcess(
399 const std::string& process_type) { 394 const std::string& process_type) {
400 // This is not used by Crashpad (at least on Windows). 395 // This is not used by Crashpad (at least on Windows).
401 NOTREACHED(); 396 NOTREACHED();
402 return true; 397 return true;
403 } 398 }
OLDNEW
« no previous file with comments | « chrome/app/chrome_crash_reporter_client_win.h ('k') | chrome/installer/setup/installer_crash_reporter_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698