Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: components/crash/content/app/breakpad_win.cc

Issue 2697513007: Windows CrashReporterClient cleanups in the wake of InstallDetails everywhere. (Closed)
Patch Set: sync to position 452911 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash/content/app/breakpad_win.cc
diff --git a/components/crash/content/app/breakpad_win.cc b/components/crash/content/app/breakpad_win.cc
index a5fb543e6514c69c69f551a5c56a221ee04e4347..c80c02303db6fca918729117233507dc48eabba9 100644
--- a/components/crash/content/app/breakpad_win.cc
+++ b/components/crash/content/app/breakpad_win.cc
@@ -555,9 +555,6 @@ void InitCrashReporter(const std::string& process_type_switch) {
exe_path[0] = 0;
GetModuleFileNameW(NULL, exe_path, MAX_PATH);
- bool is_per_user_install =
- GetCrashReporterClient()->GetIsPerUserInstall(exe_path);
-
// This is intentionally leaked.
CrashKeysWin* keeper = new CrashKeysWin();
@@ -590,7 +587,7 @@ void InitCrashReporter(const std::string& process_type_switch) {
}
if (GetCrashReporterClient()->ShouldCreatePipeName(process_type))
- InitPipeNameEnvVar(is_per_user_install);
+ InitPipeNameEnvVar(GetCrashReporterClient()->GetIsPerUserInstall());
std::unique_ptr<base::Environment> env(base::Environment::Create());
std::string pipe_name_ascii;
@@ -622,8 +619,7 @@ void InitCrashReporter(const std::string& process_type_switch) {
// Capture full memory if explicitly instructed to.
if (command.HasSwitch(switches::kFullMemoryCrashReport))
dump_type = kFullDumpType;
- else if (GetCrashReporterClient()->GetShouldDumpLargerDumps(
- is_per_user_install))
+ else if (GetCrashReporterClient()->GetShouldDumpLargerDumps())
dump_type = kLargerDumpType;
g_breakpad = new google_breakpad::ExceptionHandler(temp_dir, &FilterCallback,
« no previous file with comments | « chrome/installer/setup/installer_crash_reporter_client.cc ('k') | components/crash/content/app/crash_keys_win_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698