chrome/installer/setup/installer_crash_reporter_client.h - Issue 2697513007: Windows CrashReporterClient cleanups in the wake of InstallDetails everywhere.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/installer_crash_reporter_client.h

Issue 2697513007: Windows CrashReporterClient cleanups in the wake of InstallDetails everywhere. (Closed)

Patch Set: sync to position 452911 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/setup/installer_crash_reporter_client.h

diff --git a/chrome/installer/setup/installer_crash_reporter_client.h b/chrome/installer/setup/installer_crash_reporter_client.h

index 74f80488319eb62e4ae6cbf8cfe3b8bb4510cbde..320b5e3310f583774c08e0ea6fea8de03b23d9ec 100644

--- a/chrome/installer/setup/installer_crash_reporter_client.h

+++ b/chrome/installer/setup/installer_crash_reporter_client.h

@@ -29,8 +29,8 @@ class InstallerCrashReporterClient

bool* is_rtl_locale) override;

bool AboutToRestart() override;

bool GetDeferredUploadsSupported(bool is_per_user_install) override;

- bool GetIsPerUserInstall(const base::string16& exe_path) override;

- bool GetShouldDumpLargerDumps(bool is_per_user_install) override;

+ bool GetIsPerUserInstall() override;

+ bool GetShouldDumpLargerDumps() override;

int GetResultCodeRespawnFailed() override;

bool GetCrashDumpLocation(base::string16* crash_dir) override;

size_t RegisterCrashKeys() override;