Reland of Use spec-compliant algorithm to select video devices in getUserMedia.

Reland of Use spec-compliant algorithm to select video devices in getUserMedia. (patchset #1 id:1 of https://codereview.chromium.org/2684233005/ )


Reason for revert:
Start reland CL (without submitting to CQ)

Original issue's description:
> Revert of Use spec-compliant algorithm to select video devices in getUserMedia. (patchset #2 id:80001 of https://codereview.chromium.org/2669243004/ )
> 
> Reason for revert:
> Broke org.chromium.android_webview.test.MediaAccessPermissionRequestTest https://crbug.com/690626
> 
> Original issue's description:
> > Use spec-compliant algorithm to select video devices in getUserMedia.
> > 
> > BUG=657733
> > 
> > Review-Url: https://codereview.chromium.org/2669243004
> > Cr-Commit-Position: refs/heads/master@{#448981}
> > Committed: https://chromium.googlesource.com/chromium/src/+/9ea409c2a23810063bb280304e18b48dc6b0fe7e
> 
> TBR=mek@chromium.org,tommi@chromium.org,kinuko@chromium.org,guidou@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=657733
> 
> Review-Url: https://codereview.chromium.org/2684233005
> Cr-Commit-Position: refs/heads/master@{#449605}
> Committed: https://chromium.googlesource.com/chromium/src/+/7e9684dde3d74662e43ec427afd9ab55c8d6138d

In addition to the original patch, make the failing test use fake media devices to ensure that there is always at least one device of each kind. Without devices, the spec-compliant getUserMedia() will fail without asking for permission, which is most likely the reason the test started to fail.

TBR=mek@chromium.org,tommi@chromium.org,kinuko@chromium.org,perezju@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=657733, 690626
Review-Url: https://codereview.chromium.org/2696443002
Cr-Commit-Position: refs/heads/master@{#450026}
Committed: https://chromium.googlesource.com/chromium/src/+/28a46c315b7a01905c6509ec51b572cb89209a50

[Guido Urdaneta, 2017-02-11 13:52:56]

Created Reland of Use spec-compliant algorithm to select video devices in
getUserMedia.

[Guido Urdaneta, 2017-02-11 21:06:55]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-11 21:07:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 21:52:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 21:52:56]

Dry run: This issue passed the CQ dry run.

[Guido Urdaneta, 2017-02-11 22:18:33]

Description was changed from

==========
Reland of Use spec-compliant algorithm to select video devices in getUserMedia.
(patchset #1 id:1 of https://codereview.chromium.org/2684233005/ )

Reason for revert:
Start reland CL (without submitting to CQ)

Original issue's description:
> Revert of Use spec-compliant algorithm to select video devices in
getUserMedia. (patchset #2 id:80001 of
https://codereview.chromium.org/2669243004/ )
> 
> Reason for revert:
> Broke org.chromium.android_webview.test.MediaAccessPermissionRequestTest
https://crbug.com/690626
> 
> Original issue's description:
> > Use spec-compliant algorithm to select video devices in getUserMedia.
> > 
> > BUG=657733
> > 
> > Review-Url: https://codereview.chromium.org/2669243004
> > Cr-Commit-Position: refs/heads/master@{#448981}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/9ea409c2a23810063bb280304e18...
> 
>
TBR=mek@chromium.org,tommi@chromium.org,kinuko@chromium.org,guidou@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=657733
> 
> Review-Url: https://codereview.chromium.org/2684233005
> Cr-Commit-Position: refs/heads/master@{#449605}
> Committed:
https://chromium.googlesource.com/chromium/src/+/7e9684dde3d74662e43ec427afd9...

TBR=mek@chromium.org,tommi@chromium.org,kinuko@chromium.org,perezju@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=657733
==========

to

==========
Reland of Use spec-compliant algorithm to select video devices in getUserMedia.
(patchset #1 id:1 of https://codereview.chromium.org/2684233005/ )


Reason for revert:
Start reland CL (without submitting to CQ)

Original issue's description:
> Revert of Use spec-compliant algorithm to select video devices in
getUserMedia. (patchset #2 id:80001 of
https://codereview.chromium.org/2669243004/ )
> 
> Reason for revert:
> Broke org.chromium.android_webview.test.MediaAccessPermissionRequestTest
https://crbug.com/690626
> 
> Original issue's description:
> > Use spec-compliant algorithm to select video devices in getUserMedia.
> > 
> > BUG=657733
> > 
> > Review-Url: https://codereview.chromium.org/2669243004
> > Cr-Commit-Position: refs/heads/master@{#448981}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/9ea409c2a23810063bb280304e18...
> 
>
TBR=mek@chromium.org,tommi@chromium.org,kinuko@chromium.org,guidou@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=657733
> 
> Review-Url: https://codereview.chromium.org/2684233005
> Cr-Commit-Position: refs/heads/master@{#449605}
> Committed:
https://chromium.googlesource.com/chromium/src/+/7e9684dde3d74662e43ec427afd9...

In addition to the original patch, make the failing test use fake media devices
to ensure that there is always at least one device of each kind. Without
devices, the spec-compliant getUserMedia() will fail without asking for
permission, which is most likely the reason the test started to fail.

TBR=mek@chromium.org,tommi@chromium.org,kinuko@chromium.org,perezju@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=657733
==========

[Guido Urdaneta, 2017-02-11 22:19:28]

guidou@chromium.org changed reviewers:
+ boliu@chromium.org

[Guido Urdaneta, 2017-02-11 22:19:29]

boliu@chromium.org: Please review changes in android_webview/ and
content/public/android/

[tommi (sloooow) - chröme, 2017-02-11 23:20:04]

lgtm

[Guido Urdaneta, 2017-02-13 09:35:45]

Description was changed from

==========
Reland of Use spec-compliant algorithm to select video devices in getUserMedia.
(patchset #1 id:1 of https://codereview.chromium.org/2684233005/ )


Reason for revert:
Start reland CL (without submitting to CQ)

Original issue's description:
> Revert of Use spec-compliant algorithm to select video devices in
getUserMedia. (patchset #2 id:80001 of
https://codereview.chromium.org/2669243004/ )
> 
> Reason for revert:
> Broke org.chromium.android_webview.test.MediaAccessPermissionRequestTest
https://crbug.com/690626
> 
> Original issue's description:
> > Use spec-compliant algorithm to select video devices in getUserMedia.
> > 
> > BUG=657733
> > 
> > Review-Url: https://codereview.chromium.org/2669243004
> > Cr-Commit-Position: refs/heads/master@{#448981}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/9ea409c2a23810063bb280304e18...
> 
>
TBR=mek@chromium.org,tommi@chromium.org,kinuko@chromium.org,guidou@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=657733
> 
> Review-Url: https://codereview.chromium.org/2684233005
> Cr-Commit-Position: refs/heads/master@{#449605}
> Committed:
https://chromium.googlesource.com/chromium/src/+/7e9684dde3d74662e43ec427afd9...

In addition to the original patch, make the failing test use fake media devices
to ensure that there is always at least one device of each kind. Without
devices, the spec-compliant getUserMedia() will fail without asking for
permission, which is most likely the reason the test started to fail.

TBR=mek@chromium.org,tommi@chromium.org,kinuko@chromium.org,perezju@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=657733
==========

to

==========
Reland of Use spec-compliant algorithm to select video devices in getUserMedia.
(patchset #1 id:1 of https://codereview.chromium.org/2684233005/ )


Reason for revert:
Start reland CL (without submitting to CQ)

Original issue's description:
> Revert of Use spec-compliant algorithm to select video devices in
getUserMedia. (patchset #2 id:80001 of
https://codereview.chromium.org/2669243004/ )
> 
> Reason for revert:
> Broke org.chromium.android_webview.test.MediaAccessPermissionRequestTest
https://crbug.com/690626
> 
> Original issue's description:
> > Use spec-compliant algorithm to select video devices in getUserMedia.
> > 
> > BUG=657733
> > 
> > Review-Url: https://codereview.chromium.org/2669243004
> > Cr-Commit-Position: refs/heads/master@{#448981}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/9ea409c2a23810063bb280304e18...
> 
>
TBR=mek@chromium.org,tommi@chromium.org,kinuko@chromium.org,guidou@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=657733
> 
> Review-Url: https://codereview.chromium.org/2684233005
> Cr-Commit-Position: refs/heads/master@{#449605}
> Committed:
https://chromium.googlesource.com/chromium/src/+/7e9684dde3d74662e43ec427afd9...

In addition to the original patch, make the failing test use fake media devices
to ensure that there is always at least one device of each kind. Without
devices, the spec-compliant getUserMedia() will fail without asking for
permission, which is most likely the reason the test started to fail.

TBR=mek@chromium.org,tommi@chromium.org,kinuko@chromium.org,perezju@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=657733,690626
==========

[boliu, 2017-02-13 16:54:15]

https://codereview.chromium.org/2696443002/diff/180001/content/public/android...
File
content/public/android/java/src/org/chromium/content/common/ContentSwitches.java
(right):

https://codereview.chromium.org/2696443002/diff/180001/content/public/android...
content/public/android/java/src/org/chromium/content/common/ContentSwitches.java:77:
// Enable content intent detection in the renderer
fix comment

also delete the copy in ChromeSwitches.java and use this one instead

[Guido Urdaneta, 2017-02-13 17:26:22]

Patchset #3 (id:200001) has been deleted

[Guido Urdaneta, 2017-02-13 17:38:59]

https://codereview.chromium.org/2696443002/diff/180001/content/public/android...
File
content/public/android/java/src/org/chromium/content/common/ContentSwitches.java
(right):

https://codereview.chromium.org/2696443002/diff/180001/content/public/android...
content/public/android/java/src/org/chromium/content/common/ContentSwitches.java:77:
// Enable content intent detection in the renderer
On 2017/02/13 16:54:15, boliu wrote:
> fix comment
> 
> also delete the copy in ChromeSwitches.java and use this one instead

Fixed comment. Since ChromeSwitches is used in code unrelated to this CL, done
in separate CL https://codereview.chromium.org/2696623002/

[boliu, 2017-02-13 17:40:27]

lgtm

[Guido Urdaneta, 2017-02-13 17:41:06]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2017-02-13 17:41:07]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/2696443002/#ps220001
(title: "Address boliu's comments")

[commit-bot: I haz the power, 2017-02-13 17:41:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 18:38:10]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1487007666818730,
"parent_rev": "354db138caff746a371c025aee80b830d23ee7d0", "commit_rev":
"28a46c315b7a01905c6509ec51b572cb89209a50"}

[commit-bot: I haz the power, 2017-02-13 18:38:56]

Description was changed from

==========
Reland of Use spec-compliant algorithm to select video devices in getUserMedia.
(patchset #1 id:1 of https://codereview.chromium.org/2684233005/ )


Reason for revert:
Start reland CL (without submitting to CQ)

Original issue's description:
> Revert of Use spec-compliant algorithm to select video devices in
getUserMedia. (patchset #2 id:80001 of
https://codereview.chromium.org/2669243004/ )
> 
> Reason for revert:
> Broke org.chromium.android_webview.test.MediaAccessPermissionRequestTest
https://crbug.com/690626
> 
> Original issue's description:
> > Use spec-compliant algorithm to select video devices in getUserMedia.
> > 
> > BUG=657733
> > 
> > Review-Url: https://codereview.chromium.org/2669243004
> > Cr-Commit-Position: refs/heads/master@{#448981}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/9ea409c2a23810063bb280304e18...
> 
>
TBR=mek@chromium.org,tommi@chromium.org,kinuko@chromium.org,guidou@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=657733
> 
> Review-Url: https://codereview.chromium.org/2684233005
> Cr-Commit-Position: refs/heads/master@{#449605}
> Committed:
https://chromium.googlesource.com/chromium/src/+/7e9684dde3d74662e43ec427afd9...

In addition to the original patch, make the failing test use fake media devices
to ensure that there is always at least one device of each kind. Without
devices, the spec-compliant getUserMedia() will fail without asking for
permission, which is most likely the reason the test started to fail.

TBR=mek@chromium.org,tommi@chromium.org,kinuko@chromium.org,perezju@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=657733,690626
==========

to

==========
Reland of Use spec-compliant algorithm to select video devices in getUserMedia.
(patchset #1 id:1 of https://codereview.chromium.org/2684233005/ )


Reason for revert:
Start reland CL (without submitting to CQ)

Original issue's description:
> Revert of Use spec-compliant algorithm to select video devices in
getUserMedia. (patchset #2 id:80001 of
https://codereview.chromium.org/2669243004/ )
> 
> Reason for revert:
> Broke org.chromium.android_webview.test.MediaAccessPermissionRequestTest
https://crbug.com/690626
> 
> Original issue's description:
> > Use spec-compliant algorithm to select video devices in getUserMedia.
> > 
> > BUG=657733
> > 
> > Review-Url: https://codereview.chromium.org/2669243004
> > Cr-Commit-Position: refs/heads/master@{#448981}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/9ea409c2a23810063bb280304e18...
> 
>
TBR=mek@chromium.org,tommi@chromium.org,kinuko@chromium.org,guidou@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=657733
> 
> Review-Url: https://codereview.chromium.org/2684233005
> Cr-Commit-Position: refs/heads/master@{#449605}
> Committed:
https://chromium.googlesource.com/chromium/src/+/7e9684dde3d74662e43ec427afd9...

In addition to the original patch, make the failing test use fake media devices
to ensure that there is always at least one device of each kind. Without
devices, the spec-compliant getUserMedia() will fail without asking for
permission, which is most likely the reason the test started to fail.

TBR=mek@chromium.org,tommi@chromium.org,kinuko@chromium.org,perezju@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=657733,690626

Review-Url: https://codereview.chromium.org/2696443002
Cr-Commit-Position: refs/heads/master@{#450026}
Committed:
https://chromium.googlesource.com/chromium/src/+/28a46c315b7a01905c6509ec51b5...
==========

[commit-bot: I haz the power, 2017-02-13 18:38:58]

Committed patchset #3 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/28a46c315b7a01905c6509ec51b5...