Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: content/browser/webrtc/webrtc_getusermedia_browsertest.cc

Issue 2696443002: Reland of Use spec-compliant algorithm to select video devices in getUserMedia. (Closed)
Patch Set: Address boliu's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/webrtc/webrtc_getusermedia_browsertest.cc
diff --git a/content/browser/webrtc/webrtc_getusermedia_browsertest.cc b/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
index 64401768a6d98eb5792f0f7276937b323b0a8ef0..3dfb8284870ed9c1d6c029547b0cf1b984377b66 100644
--- a/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
+++ b/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
@@ -414,6 +414,8 @@ IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
GURL url(embedded_test_server()->GetURL("/media/getusermedia.html"));
// Test with invalid mandatory audio sourceID.
+ // TODO(guidou): Update error string when spec-compliant constraint resolution
+ // for audio is implemented. See http://crbug.com/657733.
NavigateToURL(shell(), url);
EXPECT_EQ("DevicesNotFoundError", ExecuteJavascriptAndReturnResult(
GenerateGetUserMediaWithMandatorySourceID(
@@ -422,13 +424,15 @@ IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
video_ids[0])));
// Test with invalid mandatory video sourceID.
- EXPECT_EQ("DevicesNotFoundError", ExecuteJavascriptAndReturnResult(
- GenerateGetUserMediaWithMandatorySourceID(
- kGetUserMediaAndExpectFailure,
- audio_ids[0],
- "something invalid")));
+ EXPECT_EQ("ConstraintNotSatisfiedError",
+ ExecuteJavascriptAndReturnResult(
+ GenerateGetUserMediaWithMandatorySourceID(
+ kGetUserMediaAndExpectFailure, audio_ids[0],
+ "something invalid")));
// Test with empty mandatory audio sourceID.
+ // TODO(guidou): Update error string when spec-compliant constraint resolution
+ // for audio is implemented. See http://crbug.com/657733.
EXPECT_EQ("DevicesNotFoundError", ExecuteJavascriptAndReturnResult(
GenerateGetUserMediaWithMandatorySourceID(
kGetUserMediaAndExpectFailure,

Powered by Google App Engine
This is Rietveld 408576698