Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2684233005: Revert of Use spec-compliant algorithm to select video devices in getUserMedia. (Closed)

Created:
3 years, 10 months ago by perezju
Modified:
3 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, imcheng+watch_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, nasko+codewatch_chromium.org, jam, extensions-reviews_chromium.org, avayvod+watch_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, jasonroberts+watch_google.com, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use spec-compliant algorithm to select video devices in getUserMedia. (patchset #2 id:80001 of https://codereview.chromium.org/2669243004/ ) Reason for revert: Broke org.chromium.android_webview.test.MediaAccessPermissionRequestTest https://crbug.com/690626 Original issue's description: > Use spec-compliant algorithm to select video devices in getUserMedia. > > BUG=657733 > > Review-Url: https://codereview.chromium.org/2669243004 > Cr-Commit-Position: refs/heads/master@{#448981} > Committed: https://chromium.googlesource.com/chromium/src/+/9ea409c2a23810063bb280304e18b48dc6b0fe7e TBR=mek@chromium.org,tommi@chromium.org,kinuko@chromium.org,guidou@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=657733 Review-Url: https://codereview.chromium.org/2684233005 Cr-Commit-Position: refs/heads/master@{#449605} Committed: https://chromium.googlesource.com/chromium/src/+/7e9684dde3d74662e43ec427afd9ab55c8d6138d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -298 lines) Patch
M content/browser/webrtc/webrtc_getusermedia_browsertest.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/media/mock_media_stream_dispatcher.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/mock_media_stream_dispatcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/user_media_client_impl.h View 4 chunks +6 lines, -35 lines 0 comments Download
M content/renderer/media/user_media_client_impl.cc View 7 chunks +62 lines, -139 lines 0 comments Download
M content/renderer/media/user_media_client_impl_unittest.cc View 8 chunks +49 lines, -91 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M extensions/browser/guest_view/app_view/app_view_apitest.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
perezju
Created Revert of Use spec-compliant algorithm to select video devices in getUserMedia.
3 years, 10 months ago (2017-02-10 12:49:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684233005/1
3 years, 10 months ago (2017-02-10 12:49:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7e9684dde3d74662e43ec427afd9ab55c8d6138d
3 years, 10 months ago (2017-02-10 13:35:39 UTC) #6
Guido Urdaneta
3 years, 10 months ago (2017-02-11 13:52:55 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2696443002/ by guidou@chromium.org.

The reason for reverting is: Start reland CL (without submitting to CQ).

Powered by Google App Engine
This is Rietveld 408576698