Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2178)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java

Issue 2696443002: Reland of Use spec-compliant algorithm to select video devices in getUserMedia. (Closed)
Patch Set: Address boliu's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/webrtc/webrtc_getusermedia_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java
index a5fdee3cdc6f58812401123c58c8b4bcd1c7d4ef..033312925399297c63178ab207396fc6165a4161 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java
@@ -11,9 +11,11 @@ import org.chromium.android_webview.permission.AwPermissionRequest;
import org.chromium.android_webview.test.util.CommonResources;
import org.chromium.base.annotations.SuppressFBWarnings;
import org.chromium.base.test.util.CallbackHelper;
+import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisableIf;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.RetryOnFailure;
+import org.chromium.content.common.ContentSwitches;
import org.chromium.net.test.util.TestWebServer;
import java.util.concurrent.Callable;
@@ -76,6 +78,7 @@ public class MediaAccessPermissionRequestTest extends AwTestBase {
@Feature({"AndroidWebView"})
@SmallTest
@DisableIf.Build(sdk_is_greater_than = 22, message = "crbug.com/623921")
+ @CommandLineFlags.Add(ContentSwitches.USE_FAKE_DEVICE_FOR_MEDIA_STREAM)
@RetryOnFailure
public void testGrantAccess() throws Throwable {
final OnPermissionRequestHelper helper = new OnPermissionRequestHelper();
@@ -100,6 +103,7 @@ public class MediaAccessPermissionRequestTest extends AwTestBase {
@Feature({"AndroidWebView"})
@SmallTest
@DisableIf.Build(sdk_is_greater_than = 22, message = "crbug.com/614347")
+ @CommandLineFlags.Add(ContentSwitches.USE_FAKE_DEVICE_FOR_MEDIA_STREAM)
@RetryOnFailure
public void testDenyAccess() throws Throwable {
final OnPermissionRequestHelper helper = new OnPermissionRequestHelper();
@@ -134,6 +138,7 @@ public class MediaAccessPermissionRequestTest extends AwTestBase {
@Feature({"AndroidWebView"})
@SmallTest
@DisableIf.Build(sdk_is_greater_than = 22, message = "crbug.com/614347")
+ @CommandLineFlags.Add(ContentSwitches.USE_FAKE_DEVICE_FOR_MEDIA_STREAM)
@RetryOnFailure
public void testDenyAccessByDefault() throws Throwable {
final OnPermissionRequestHelper helper = new OnPermissionRequestHelper();
@@ -171,6 +176,7 @@ public class MediaAccessPermissionRequestTest extends AwTestBase {
@Feature({"AndroidWebView"})
@SmallTest
@DisableIf.Build(sdk_is_greater_than = 22, message = "crbug.com/614347")
+ @CommandLineFlags.Add(ContentSwitches.USE_FAKE_DEVICE_FOR_MEDIA_STREAM)
@RetryOnFailure
public void testCancelPermission() throws Throwable {
final OnPermissionRequestHelper helper = new OnPermissionRequestHelper();
« no previous file with comments | « no previous file | content/browser/webrtc/webrtc_getusermedia_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698