Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2669243004: Use spec-compliant algorithm to select video devices in getUserMedia. (Closed)

Created:
3 years, 10 months ago by Guido Urdaneta
Modified:
3 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, imcheng+watch_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, nasko+codewatch_chromium.org, jam, extensions-reviews_chromium.org, avayvod+watch_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, jasonroberts+watch_google.com, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use spec-compliant algorithm to select video devices in getUserMedia. BUG=657733 Review-Url: https://codereview.chromium.org/2669243004 Cr-Commit-Position: refs/heads/master@{#448981} Committed: https://chromium.googlesource.com/chromium/src/+/9ea409c2a23810063bb280304e18b48dc6b0fe7e

Patch Set 1 #

Total comments: 2

Patch Set 2 : address tommi's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -123 lines) Patch
M content/browser/webrtc/webrtc_getusermedia_browsertest.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_dispatcher.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/media/mock_media_stream_dispatcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/mock_media_stream_dispatcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/user_media_client_impl.h View 1 4 chunks +35 lines, -6 lines 0 comments Download
M content/renderer/media/user_media_client_impl.cc View 7 chunks +128 lines, -51 lines 0 comments Download
M content/renderer/media/user_media_client_impl_unittest.cc View 8 chunks +88 lines, -46 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/app_view/app_view_apitest.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 28 (19 generated)
Guido Urdaneta
Hi, PTAL mek@chromium.org: Please review changes in extensions/ tommi@chromium.org: Please review changes in content/
3 years, 10 months ago (2017-02-03 16:44:44 UTC) #13
Marijn Kruisselbrink
extensions lgtm
3 years, 10 months ago (2017-02-03 17:39:15 UTC) #14
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/2669243004/diff/60001/content/renderer/media/user_media_client_impl.cc File content/renderer/media/user_media_client_impl.cc (right): https://codereview.chromium.org/2669243004/diff/60001/content/renderer/media/user_media_client_impl.cc#newcode242 content/renderer/media/user_media_client_impl.cc:242: worker_task_runner_(worker_task_runner), can worker_task_runner_ be const?
3 years, 10 months ago (2017-02-03 18:03:06 UTC) #17
Guido Urdaneta
https://codereview.chromium.org/2669243004/diff/60001/content/renderer/media/user_media_client_impl.cc File content/renderer/media/user_media_client_impl.cc (right): https://codereview.chromium.org/2669243004/diff/60001/content/renderer/media/user_media_client_impl.cc#newcode242 content/renderer/media/user_media_client_impl.cc:242: worker_task_runner_(worker_task_runner), On 2017/02/03 18:03:06, tommi (krómíum) wrote: > can ...
3 years, 10 months ago (2017-02-03 21:33:04 UTC) #18
Guido Urdaneta
kinuko@chromium.org: Can you take a look or rs content/renderer/render_frame_impl.cc?
3 years, 10 months ago (2017-02-03 21:34:22 UTC) #20
kinuko
lgtm
3 years, 10 months ago (2017-02-04 00:02:48 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669243004/80001
3 years, 10 months ago (2017-02-08 12:47:12 UTC) #24
commit-bot: I haz the power
Committed patchset #2 (id:80001) as https://chromium.googlesource.com/chromium/src/+/9ea409c2a23810063bb280304e18b48dc6b0fe7e
3 years, 10 months ago (2017-02-08 13:54:54 UTC) #27
perezju
3 years, 10 months ago (2017-02-10 12:49:06 UTC) #28
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:80001) has been created in
https://codereview.chromium.org/2684233005/ by perezju@chromium.org.

The reason for reverting is: Broke
org.chromium.android_webview.test.MediaAccessPermissionRequestTest
https://crbug.com/690626.

Powered by Google App Engine
This is Rietveld 408576698