Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2696623002: Migrate uses of ChromeSwitches.USE_FAKE_DEVICE_FOR_MEDIA_STREAM to ContentSwithes. (Closed)

Created:
3 years, 10 months ago by Guido Urdaneta
Modified:
3 years, 10 months ago
Reviewers:
boliu, gone
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, raymes+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate uses of ChromeSwitches.USE_FAKE_DEVICE_FOR_MEDIA_STREAM to ContentSwithes. And remove the ChromeSwitches version. BUG=690626 Review-Url: https://codereview.chromium.org/2696623002 Cr-Commit-Position: refs/heads/master@{#450110} Committed: https://chromium.googlesource.com/chromium/src/+/027a80427f6088e66fe7ec024f1dcae7c21e0205

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/permissions/MediaTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java View 6 chunks +5 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
Guido Urdaneta
Hi, PTAL
3 years, 10 months ago (2017-02-13 17:43:04 UTC) #6
boliu
non-owner lgtm
3 years, 10 months ago (2017-02-13 17:50:10 UTC) #7
gone
lgtm
3 years, 10 months ago (2017-02-13 19:24:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696623002/1
3 years, 10 months ago (2017-02-13 21:54:38 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 22:07:52 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/027a80427f6088e66fe7ec024f1d...

Powered by Google App Engine
This is Rietveld 408576698