Implement VTTCue.region and sync the VTTRegion interface

Implement VTTCue.region and sync the VTTRegion interface

This CL implements the VTTCue.region property, replacing 'regionId'. The
main implementation mechanism is a new map in VTTParser that tracks the
regions currently seen.

Rewrite the region parser test to be based on cues rather than the list
of regions. This will ease the removal of TextTrack.regions.

Sync the VTTRegion with the current spec by

 * renaming the 'height' property to 'lines',

 * adding and using the ScrollSetting IDL enumeration type and

 * dropping the 'id' and 'track' properties.

Update tests as needed to match the above changes.

BUG=690014
Review-Url: https://codereview.chromium.org/2682333002
Cr-Commit-Position: refs/heads/master@{#449589}
Committed: https://chromium.googlesource.com/chromium/src/+/037ca4bef92ddae569a757a66006d60cfcc7bdc5

[fs, 2017-02-09 16:25:34]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 16:25:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 18:21:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 18:21:03]

Dry run: This issue passed the CQ dry run.

[fs, 2017-02-09 19:08:18]

fs@opera.com changed reviewers:
+ foolip@chromium.org

[fs, 2017-02-09 19:08:18]

In preparation of TextTrack.regions (et al) removal... turns out it's easier to
add VTTCue.region before ripping out TextTrack.regions, since it avoid killing
test-coverage entirely. The removal is in the dependent CL.

[foolip, 2017-02-09 19:37:46]

lgtm

https://codereview.chromium.org/2682333002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp (left):

https://codereview.chromium.org/2682333002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp:815: // TODO(foolip):
The region identifier may be non-empty without there being
another one bites the dust, thanks :)

https://codereview.chromium.org/2682333002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp (right):

https://codereview.chromium.org/2682333002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp:114:
m_regionMap.clear();
I thought this was wrong, but apparently VTTParser::flush() is called only from
once the resources us fully loaded and finished parsing.

https://codereview.chromium.org/2682333002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp (right):

https://codereview.chromium.org/2682333002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp:155: m_scroll =
value != emptyAtom;
Also DCHECK what the other possible value is, in case the IDL enum gets
expanded?

[fs, 2017-02-10 08:51:29]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 08:51:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-02-10 08:52:07]

https://codereview.chromium.org/2682333002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp (right):

https://codereview.chromium.org/2682333002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp:155: m_scroll =
value != emptyAtom;
On 2017/02/09 at 19:37:46, foolip wrote:
> Also DCHECK what the other possible value is, in case the IDL enum gets
expanded?

DCHECK added.

[commit-bot: I haz the power, 2017-02-10 10:39:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 10:39:09]

Dry run: This issue passed the CQ dry run.

[fs, 2017-02-10 11:26:01]

The CQ bit was checked by fs@opera.com

[fs, 2017-02-10 11:26:02]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2682333002/#ps20001
(title: "Add DCHECK")

[commit-bot: I haz the power, 2017-02-10 11:26:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 11:30:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486725961302830,
"parent_rev": "75d9c7e22b281a5e22a6382b9f9a2d9a9dbeac4f", "commit_rev":
"037ca4bef92ddae569a757a66006d60cfcc7bdc5"}

[commit-bot: I haz the power, 2017-02-10 11:31:09]

Description was changed from

==========
Implement VTTCue.region and sync the VTTRegion interface

This CL implements the VTTCue.region property, replacing 'regionId'. The
main implementation mechanism is a new map in VTTParser that tracks the
regions currently seen.

Rewrite the region parser test to be based on cues rather than the list
of regions. This will ease the removal of TextTrack.regions.

Sync the VTTRegion with the current spec by

 * renaming the 'height' property to 'lines',

 * adding and using the ScrollSetting IDL enumeration type and

 * dropping the 'id' and 'track' properties.

Update tests as needed to match the above changes.

BUG=690014
==========

to

==========
Implement VTTCue.region and sync the VTTRegion interface

This CL implements the VTTCue.region property, replacing 'regionId'. The
main implementation mechanism is a new map in VTTParser that tracks the
regions currently seen.

Rewrite the region parser test to be based on cues rather than the list
of regions. This will ease the removal of TextTrack.regions.

Sync the VTTRegion with the current spec by

 * renaming the 'height' property to 'lines',

 * adding and using the ScrollSetting IDL enumeration type and

 * dropping the 'id' and 'track' properties.

Update tests as needed to match the above changes.

BUG=690014

Review-Url: https://codereview.chromium.org/2682333002
Cr-Commit-Position: refs/heads/master@{#449589}
Committed:
https://chromium.googlesource.com/chromium/src/+/037ca4bef92ddae569a757a66006...
==========

[commit-bot: I haz the power, 2017-02-10 11:31:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/037ca4bef92ddae569a757a66006...