third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp - Issue 2682333002: Implement VTTCue.region and sync the VTTRegion interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp

Issue 2682333002: Implement VTTCue.region and sync the VTTRegion interface (Closed)

Patch Set: Add DCHECK Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp

diff --git a/third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp b/third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp

index 00f64ef885158274e954e245218d1123bd2b49f4..fd4b716389d081c497b0dc039b4e6e74f4306867 100644

--- a/third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp

+++ b/third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp

@@ -97,7 +97,7 @@ void InbandTextTrack::addWebVTTCue(double start,

DCHECK(owner);

VTTCue* cue = VTTCue::create(owner->document(), start, end, content);

cue->setId(id);

- cue->parseSettings(settings);

+ cue->parseSettings(nullptr, settings);

addCue(cue);

}