third_party/WebKit/Source/core/html/track/vtt/VTTCue.idl - Issue 2682333002: Implement VTTCue.region and sync the VTTRegion interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/vtt/VTTCue.idl

Issue 2682333002: Implement VTTCue.region and sync the VTTRegion interface (Closed)

Patch Set: Add DCHECK Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/track/vtt/VTTCue.idl

diff --git a/third_party/WebKit/Source/core/html/track/vtt/VTTCue.idl b/third_party/WebKit/Source/core/html/track/vtt/VTTCue.idl

index 090a8a3ed49f57490190c96251ecb71dfe986bac..58e5c79194cfd1c2b9ded0aacf2798684ffc2bb2 100644

--- a/third_party/WebKit/Source/core/html/track/vtt/VTTCue.idl

+++ b/third_party/WebKit/Source/core/html/track/vtt/VTTCue.idl

@@ -40,8 +40,7 @@ enum AlignSetting { "start", "middle", "end", "left", "right" };

ConstructorCallWith=Document,

DependentLifetime,

] interface VTTCue : TextTrackCue {

- // TODO(foolip): regionId has been replaced by a region attribute.

- [RuntimeEnabled=WebVTTRegions] attribute DOMString regionId;

+ [RuntimeEnabled=WebVTTRegions] attribute VTTRegion? region;

attribute DirectionSetting vertical;

attribute boolean snapToLines;

attribute (double or AutoKeyword) line;