third_party/WebKit/Source/core/html/track/LoadableTextTrack.cpp - Issue 2682333002: Implement VTTCue.region and sync the VTTRegion interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/LoadableTextTrack.cpp

Issue 2682333002: Implement VTTCue.region and sync the VTTRegion interface (Closed)

Patch Set: Add DCHECK Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/track/LoadableTextTrack.cpp

diff --git a/third_party/WebKit/Source/core/html/track/LoadableTextTrack.cpp b/third_party/WebKit/Source/core/html/track/LoadableTextTrack.cpp

index 6f7872b19fc9f0cc4c109bf350944bc70cec8e71..7d6c02ff6d92463e7d405a842fed072428068c10 100644

--- a/third_party/WebKit/Source/core/html/track/LoadableTextTrack.cpp

+++ b/third_party/WebKit/Source/core/html/track/LoadableTextTrack.cpp

@@ -55,10 +55,8 @@ void LoadableTextTrack::setMode(const AtomicString& mode) {

void LoadableTextTrack::addRegions(

const HeapVector<Member<VTTRegion>>& newRegions) {

- for (const auto& region : newRegions) {

- region->setTrack(this);

+ for (const auto& region : newRegions)

regions()->add(region);

- }

}

size_t LoadableTextTrack::trackElementIndex() const {