Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: third_party/WebKit/LayoutTests/media/track/regions-webvtt/vtt-region-constructor.html

Issue 2682333002: Implement VTTCue.region and sync the VTTRegion interface (Closed)
Patch Set: Add DCHECK Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/track/regions-webvtt/vtt-region-constructor.html
diff --git a/third_party/WebKit/LayoutTests/media/track/regions-webvtt/vtt-region-constructor.html b/third_party/WebKit/LayoutTests/media/track/regions-webvtt/vtt-region-constructor.html
index 1eb5d81bc24242576e4ce26a436b0d3be71c7794..d0c263d5e18e955b3edd2075d829b22cfc8b5162 100644
--- a/third_party/WebKit/LayoutTests/media/track/regions-webvtt/vtt-region-constructor.html
+++ b/third_party/WebKit/LayoutTests/media/track/regions-webvtt/vtt-region-constructor.html
@@ -7,16 +7,15 @@ test(function() {
var region = new VTTRegion();
assert_true(region instanceof VTTRegion, "instanceof");
- assert_equals(region.track, null);
assert_equals(region.scroll, "");
assert_equals(region.viewportAnchorX, 0);
assert_equals(region.viewportAnchorY, 100);
assert_equals(region.regionAnchorX, 0);
assert_equals(region.regionAnchorY, 100);
- assert_equals(region.height, 3);
+ assert_equals(region.lines, 3);
assert_equals(region.width, 100);
- assert_throws(new SyntaxError, function() { region.scroll = "invalid-scroll-value"; });
+ region.scroll = "invalid-scroll-value";
assert_equals(region.scroll, "");
var invalidPercentageValues = [-1, 101];
@@ -47,11 +46,11 @@ test(function() {
assert_equals(region.width, 100);
}
- assert_throws("IndexSizeError", function() { region.height = -1; });
- assert_equals(region.height, 3);
+ assert_throws("IndexSizeError", function() { region.lines = -1; });
+ assert_equals(region.lines, 3);
- region.height = 130;
- assert_equals(region.height, 130);
+ region.lines = 130;
+ assert_equals(region.lines, 130);
region.viewportAnchorX = 64;
assert_equals(region.viewportAnchorX, 64);
region.viewportAnchorY = 32;

Powered by Google App Engine
This is Rietveld 408576698