Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp

Issue 2682333002: Implement VTTCue.region and sync the VTTRegion interface (Closed)
Patch Set: Add DCHECK Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 90
91 void InbandTextTrack::addWebVTTCue(double start, 91 void InbandTextTrack::addWebVTTCue(double start,
92 double end, 92 double end,
93 const WebString& id, 93 const WebString& id,
94 const WebString& content, 94 const WebString& content,
95 const WebString& settings) { 95 const WebString& settings) {
96 HTMLMediaElement* owner = mediaElement(); 96 HTMLMediaElement* owner = mediaElement();
97 DCHECK(owner); 97 DCHECK(owner);
98 VTTCue* cue = VTTCue::create(owner->document(), start, end, content); 98 VTTCue* cue = VTTCue::create(owner->document(), start, end, content);
99 cue->setId(id); 99 cue->setId(id);
100 cue->parseSettings(settings); 100 cue->parseSettings(nullptr, settings);
101 addCue(cue); 101 addCue(cue);
102 } 102 }
103 103
104 } // namespace blink 104 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698