Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: services/shape_detection/public/interfaces/facedetection.mojom

Issue 2681913003: RELAND: ShapeDetection: use mojom::Bitmap for mojo interface. (Closed)
Patch Set: Fix the issue of failing to fetch bitmap module Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/shape_detection/public/interfaces/facedetection.mojom
diff --git a/services/shape_detection/public/interfaces/facedetection.mojom b/services/shape_detection/public/interfaces/facedetection.mojom
index 38102f80b0978b7a4aaadbc25249984207d80299..0ee139065b128d03942b5f9cf55498f8a5caf699 100644
--- a/services/shape_detection/public/interfaces/facedetection.mojom
+++ b/services/shape_detection/public/interfaces/facedetection.mojom
@@ -6,6 +6,7 @@
module shape_detection.mojom;
+import "skia/public/interfaces/bitmap.mojom";
import "ui/gfx/geometry/mojo/geometry.mojom";
// Since "//ui/gfx/geometry/mojo" is not exposed to blink, we need to declare
@@ -21,9 +22,7 @@ struct FaceDetectorOptions {
};
interface FaceDetection {
- // |frame_data| contains tightly packed image pixels in ARGB32 format,
- // row-major order.
- // TODO(mcasas): Consider using mojo::Bitmap here, https://crbug.com/665488.
- Detect(handle<shared_buffer> frame_data, uint32 width, uint32 height)
+ // |bitmap_data| contains tightly packed image pixels in row-major order.
+ Detect(skia.mojom.Bitmap bitmap_data)
=> (FaceDetectionResult result);
};

Powered by Google App Engine
This is Rietveld 408576698