Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: services/shape_detection/barcode_detection_impl_mac.mm

Issue 2681913003: RELAND: ShapeDetection: use mojom::Bitmap for mojo interface. (Closed)
Patch Set: Fix the issue of failing to fetch bitmap module Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/shape_detection/barcode_detection_impl_mac.mm
diff --git a/services/shape_detection/barcode_detection_impl_mac.mm b/services/shape_detection/barcode_detection_impl_mac.mm
index ec0ac0bb6219482cdf7e8124cc9dfa566a7470cd..2abbc03406a34ddea960f2c5d539b9c984e3863a 100644
--- a/services/shape_detection/barcode_detection_impl_mac.mm
+++ b/services/shape_detection/barcode_detection_impl_mac.mm
@@ -50,22 +50,20 @@ BarcodeDetectionImplMac::BarcodeDetectionImplMac() {
BarcodeDetectionImplMac::~BarcodeDetectionImplMac() {}
-void BarcodeDetectionImplMac::Detect(mojo::ScopedSharedBufferHandle frame_data,
- uint32_t width,
- uint32_t height,
+void BarcodeDetectionImplMac::Detect(const SkBitmap& bitmap,
const DetectCallback& callback) {
media::ScopedResultCallback<DetectCallback> scoped_callback(
base::Bind(&RunCallbackWithBarcodes, callback),
base::Bind(&RunCallbackWithNoBarcodes));
- base::scoped_nsobject<CIImage> ci_image =
- CreateCIImageFromSharedMemory(std::move(frame_data), width, height);
+ base::scoped_nsobject<CIImage> ci_image = CreateCIImageFromSkBitmap(bitmap);
if (!ci_image)
return;
NSArray* const features = [detector_ featuresInImage:ci_image];
std::vector<mojom::BarcodeDetectionResultPtr> results;
+ const int height = bitmap.height();
for (CIQRCodeFeature* const f in features) {
shape_detection::mojom::BarcodeDetectionResultPtr result =
shape_detection::mojom::BarcodeDetectionResult::New();
« no previous file with comments | « services/shape_detection/barcode_detection_impl_mac.h ('k') | services/shape_detection/barcode_detection_impl_mac_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698