Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Issue 2696143002: Revert of RELAND: ShapeDetection: use mojom::Bitmap for mojo interface. (Closed)

Created:
3 years, 10 months ago by perkj_chrome
Modified:
3 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, agrieve+watch_chromium.org, blink-reviews, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, mac-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of RELAND: ShapeDetection: use mojom::Bitmap for mojo interface. (patchset #4 id:180001 of https://codereview.chromium.org/2681913003/ ) Reason for revert: Sorry - but this breaks blink layout tests on mac: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/16336 Original issue's description: > RELAND: ShapeDetection: use mojom::Bitmap for mojo interface. > > Original CL got reverted due to conflit with another landed CL that need > to use mojom::bitmap. > > Original CL description ------------------------------------------------ > ShapeDetection: use mojom::Bitmap for mojo interface. > > This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition, > so that the Detect API is completely flexible and friendly. > > BUG=665488 > TEST(Layout)= > third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html > third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html > third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html > third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html > third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html > third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html > third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html > > Review-Url: https://codereview.chromium.org/2629433003 > Cr-Commit-Position: refs/heads/master@{#446142} > (cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68) > > Conflicts: > third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp > third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2681913003 > Cr-Commit-Position: refs/heads/master@{#450582} > Committed: https://chromium.googlesource.com/chromium/src/+/ab1a9331a441fa315edb669486ac1964788e47c7 TBR=rockot@chromium.org,dtrainor@chromium.org,haraken@chromium.org,leon.han@intel.com,mcasas@chromium.org,tsepez@chromium.org,xianglu@chromium.org,reed@google.com,bsalomon@google.com,junwei.fu@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=665488 Review-Url: https://codereview.chromium.org/2696143002 Cr-Commit-Position: refs/heads/master@{#450625} Committed: https://chromium.googlesource.com/chromium/src/+/7b9838f84b0aef41622e9468ded89d0e52a3280f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -158 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java View 4 chunks +6 lines, -16 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java View 4 chunks +6 lines, -16 lines 0 comments Download
M content/public/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionImpl.java View 2 chunks +11 lines, -23 lines 0 comments Download
M services/shape_detection/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M services/shape_detection/barcode_detection_impl_mac.h View 2 chunks +3 lines, -2 lines 0 comments Download
M services/shape_detection/barcode_detection_impl_mac.mm View 1 chunk +5 lines, -3 lines 0 comments Download
M services/shape_detection/barcode_detection_impl_mac_unittest.mm View 3 chunks +19 lines, -5 lines 0 comments Download
M services/shape_detection/detection_utils_mac.h View 1 chunk +4 lines, -3 lines 0 comments Download
M services/shape_detection/detection_utils_mac.mm View 1 chunk +42 lines, -12 lines 0 comments Download
M services/shape_detection/face_detection_impl_mac.h View 2 chunks +3 lines, -2 lines 0 comments Download
M services/shape_detection/face_detection_impl_mac.mm View 1 chunk +5 lines, -3 lines 0 comments Download
M services/shape_detection/face_detection_impl_mac_unittest.mm View 1 chunk +14 lines, -2 lines 0 comments Download
M services/shape_detection/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/shape_detection/public/interfaces/barcodedetection.mojom View 2 chunks +4 lines, -3 lines 0 comments Download
M services/shape_detection/public/interfaces/facedetection.mojom View 2 chunks +4 lines, -3 lines 0 comments Download
M services/shape_detection/public/interfaces/textdetection.mojom View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/shapedetection/resources/mock-barcodedetection.js View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp View 2 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/FaceDetector.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp View 5 chunks +59 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/TextDetector.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
perkj_chrome
Created Revert of RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.
3 years, 10 months ago (2017-02-15 07:34:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696143002/1
3 years, 10 months ago (2017-02-15 07:34:32 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 07:36:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7b9838f84b0aef41622e9468ded8...

Powered by Google App Engine
This is Rietveld 408576698