DescriptionRevert of RELAND: ShapeDetection: use mojom::Bitmap for mojo interface. (patchset #4 id:180001 of https://codereview.chromium.org/2681913003/ )
Reason for revert:
Sorry - but this breaks blink layout tests on mac:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/16336
Original issue's description:
> RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.
>
> Original CL got reverted due to conflit with another landed CL that need
> to use mojom::bitmap.
>
> Original CL description ------------------------------------------------
> ShapeDetection: use mojom::Bitmap for mojo interface.
>
> This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
> so that the Detect API is completely flexible and friendly.
>
> BUG=665488
> TEST(Layout)=
> third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
> third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
> third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
> third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
> third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
> third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
> third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
>
> Review-Url: https://codereview.chromium.org/2629433003
> Cr-Commit-Position: refs/heads/master@{#446142}
> (cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68)
>
> Conflicts:
> third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
> third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2681913003
> Cr-Commit-Position: refs/heads/master@{#450582}
> Committed: https://chromium.googlesource.com/chromium/src/+/ab1a9331a441fa315edb669486ac1964788e47c7
TBR=rockot@chromium.org,dtrainor@chromium.org,haraken@chromium.org,leon.han@intel.com,mcasas@chromium.org,tsepez@chromium.org,xianglu@chromium.org,reed@google.com,bsalomon@google.com,junwei.fu@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=665488
Review-Url: https://codereview.chromium.org/2696143002
Cr-Commit-Position: refs/heads/master@{#450625}
Committed: https://chromium.googlesource.com/chromium/src/+/7b9838f84b0aef41622e9468ded89d0e52a3280f
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|