Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 2742793003: Adds blink_tests -> mojo test interfaces runtime dependency. (Closed)

Created:
3 years, 9 months ago by alokp
Modified:
3 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, yzshen1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds blink_tests -> mojo test interfaces runtime dependency. This is so that mojo/binding.html can find the generated bindings for math_calculator.mojom. This layout test was added in r455925, but failed to add this data dependency. BUG=700281 TEST=gn desc blink_tests runtime_deps Review-Url: https://codereview.chromium.org/2742793003 Cr-Commit-Position: refs/heads/master@{#456119} Committed: https://chromium.googlesource.com/chromium/src/+/51b900d1d15eee1867ffdc2a3d32cc69b439ea21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
alokp
3 years, 9 months ago (2017-03-10 14:50:04 UTC) #2
Dirk Pranke
lgtm
3 years, 9 months ago (2017-03-10 17:41:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742793003/1
3 years, 9 months ago (2017-03-10 17:56:58 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 18:57:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/51b900d1d15eee1867ffdc2a3d32...

Powered by Google App Engine
This is Rietveld 408576698