RELAND: Shape Detection: move the Mac service to the sandboxed GPU process

RELAND: Shape Detection: move the Mac service to the sandboxed GPU process

Original CL got reverted due to 
fast/shapedetection/shapedetection-security-test.html 
getting flaky on Mac bots; output logs said "gpu process crashed". 

This CL moves this test html to the normal (not-fast) test folder so 
it can use the Mojo mock instead of the real one in content_shell.
This is OK since the test essentially triggers rejection paths in Blink
code only.


Original CL description	 ------------------------------------------------

Shape Detection: move the Mac service to the sandboxed GPU process

ShapeDetection in Mac uses privileged and potentially dangerous APIs
inside CoreImage and perhaps more, transitively.  This CL moves the
shape detection service to run in the GPU process, which is sandboxed.

The reason for using the GPU process is that CoreImage APIs seem
to depend strongly and mysteriously on the GPU, as I learned while
trying to get the unittests to work [1] in our normal mac bots (which
are virtual machines and have no GPU).  I tried using a sw rendering
context and a coupe of other circumventions but nothing really worked.

[1] early PSs in https://codereview.chromium.org/2677553003/

BUG=666143
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2739163003
Cr-Commit-Position: refs/heads/master@{#456555}

TBR=rockot@chromium.org, rsesek@chromium.org, kbr@chromium.org
since the gist of the CL hasn't changed.

Review-Url: https://codereview.chromium.org/2756793002
Cr-Commit-Position: refs/heads/master@{#457656}
Committed: https://chromium.googlesource.com/chromium/src/+/73550c046bb7db4ee5af46e4a161946ddfe5ec3a

[mcasas, 2017-03-16 23:37:49]

Description was changed from

==========
RELAND: Shape Detection: move the Mac service to the sandboxed GPU process

Original CL description	 ------------------------------------------------

Shape Detection: move the Mac service to the sandboxed GPU process

ShapeDetection in Mac uses privileged and potentially dangerous APIs
inside CoreImage and perhaps more, transitively.  This CL moves the
shape detection service to run in the GPU process, which is sandboxed.

The reason for using the GPU process is that CoreImage APIs seem
to depend strongly and mysteriously on the GPU, as I learned while
trying to get the unittests to work [1] in our normal mac bots (which
are virtual machines and have no GPU).  I tried using a sw rendering
context and a coupe of other circumventions but nothing really worked.

[1] early PSs in https://codereview.chromium.org/2677553003/

BUG=666143
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2739163003
Cr-Commit-Position: refs/heads/master@{#456555}
==========

to

==========
RELAND: Shape Detection: move the Mac service to the sandboxed GPU process

Original CL got reverted due to 
fast/shapedetection/shapedetection-security-test.html getting flaky on 
Mac bots.

This CL moves that to non-fast test folder so we can use a Mojo mock.


Original CL description	 ------------------------------------------------

Shape Detection: move the Mac service to the sandboxed GPU process

ShapeDetection in Mac uses privileged and potentially dangerous APIs
inside CoreImage and perhaps more, transitively.  This CL moves the
shape detection service to run in the GPU process, which is sandboxed.

The reason for using the GPU process is that CoreImage APIs seem
to depend strongly and mysteriously on the GPU, as I learned while
trying to get the unittests to work [1] in our normal mac bots (which
are virtual machines and have no GPU).  I tried using a sw rendering
context and a coupe of other circumventions but nothing really worked.

[1] early PSs in https://codereview.chromium.org/2677553003/

BUG=666143
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2739163003
Cr-Commit-Position: refs/heads/master@{#456555}
==========

[mcasas, 2017-03-16 23:39:44]

Description was changed from

==========
RELAND: Shape Detection: move the Mac service to the sandboxed GPU process

Original CL got reverted due to 
fast/shapedetection/shapedetection-security-test.html getting flaky on 
Mac bots.

This CL moves that to non-fast test folder so we can use a Mojo mock.


Original CL description	 ------------------------------------------------

Shape Detection: move the Mac service to the sandboxed GPU process

ShapeDetection in Mac uses privileged and potentially dangerous APIs
inside CoreImage and perhaps more, transitively.  This CL moves the
shape detection service to run in the GPU process, which is sandboxed.

The reason for using the GPU process is that CoreImage APIs seem
to depend strongly and mysteriously on the GPU, as I learned while
trying to get the unittests to work [1] in our normal mac bots (which
are virtual machines and have no GPU).  I tried using a sw rendering
context and a coupe of other circumventions but nothing really worked.

[1] early PSs in https://codereview.chromium.org/2677553003/

BUG=666143
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2739163003
Cr-Commit-Position: refs/heads/master@{#456555}
==========

to

==========
RELAND: Shape Detection: move the Mac service to the sandboxed GPU process

Original CL got reverted due to 
fast/shapedetection/shapedetection-security-test.html getting flaky on 
Mac bots: output logs said "gpu process crashed". 

This CL moves that to non-fast test folder so we can use a Mojo mock.


Original CL description	 ------------------------------------------------

Shape Detection: move the Mac service to the sandboxed GPU process

ShapeDetection in Mac uses privileged and potentially dangerous APIs
inside CoreImage and perhaps more, transitively.  This CL moves the
shape detection service to run in the GPU process, which is sandboxed.

The reason for using the GPU process is that CoreImage APIs seem
to depend strongly and mysteriously on the GPU, as I learned while
trying to get the unittests to work [1] in our normal mac bots (which
are virtual machines and have no GPU).  I tried using a sw rendering
context and a coupe of other circumventions but nothing really worked.

[1] early PSs in https://codereview.chromium.org/2677553003/

BUG=666143
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2739163003
Cr-Commit-Position: refs/heads/master@{#456555}
==========

[mcasas, 2017-03-17 00:11:02]

Description was changed from

==========
RELAND: Shape Detection: move the Mac service to the sandboxed GPU process

Original CL got reverted due to 
fast/shapedetection/shapedetection-security-test.html getting flaky on 
Mac bots: output logs said "gpu process crashed". 

This CL moves that to non-fast test folder so we can use a Mojo mock.


Original CL description	 ------------------------------------------------

Shape Detection: move the Mac service to the sandboxed GPU process

ShapeDetection in Mac uses privileged and potentially dangerous APIs
inside CoreImage and perhaps more, transitively.  This CL moves the
shape detection service to run in the GPU process, which is sandboxed.

The reason for using the GPU process is that CoreImage APIs seem
to depend strongly and mysteriously on the GPU, as I learned while
trying to get the unittests to work [1] in our normal mac bots (which
are virtual machines and have no GPU).  I tried using a sw rendering
context and a coupe of other circumventions but nothing really worked.

[1] early PSs in https://codereview.chromium.org/2677553003/

BUG=666143
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2739163003
Cr-Commit-Position: refs/heads/master@{#456555}
==========

to

==========
RELAND: Shape Detection: move the Mac service to the sandboxed GPU process

Original CL got reverted due to 
fast/shapedetection/shapedetection-security-test.html 
getting flaky on Mac bots; output logs said "gpu process crashed". 

This CL moves this test html to the normal (not-fast) test folder so 
it can use the Mojo mock instead of the real one in content_shell.
This is OK since the test essentially triggers rejection paths in Blink
code only.


Original CL description	 ------------------------------------------------

Shape Detection: move the Mac service to the sandboxed GPU process

ShapeDetection in Mac uses privileged and potentially dangerous APIs
inside CoreImage and perhaps more, transitively.  This CL moves the
shape detection service to run in the GPU process, which is sandboxed.

The reason for using the GPU process is that CoreImage APIs seem
to depend strongly and mysteriously on the GPU, as I learned while
trying to get the unittests to work [1] in our normal mac bots (which
are virtual machines and have no GPU).  I tried using a sw rendering
context and a coupe of other circumventions but nothing really worked.

[1] early PSs in https://codereview.chromium.org/2677553003/

BUG=666143
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2739163003
Cr-Commit-Position: refs/heads/master@{#456555}
==========

[mcasas, 2017-03-17 00:12:46]

Description was changed from

==========
RELAND: Shape Detection: move the Mac service to the sandboxed GPU process

Original CL got reverted due to 
fast/shapedetection/shapedetection-security-test.html 
getting flaky on Mac bots; output logs said "gpu process crashed". 

This CL moves this test html to the normal (not-fast) test folder so 
it can use the Mojo mock instead of the real one in content_shell.
This is OK since the test essentially triggers rejection paths in Blink
code only.


Original CL description	 ------------------------------------------------

Shape Detection: move the Mac service to the sandboxed GPU process

ShapeDetection in Mac uses privileged and potentially dangerous APIs
inside CoreImage and perhaps more, transitively.  This CL moves the
shape detection service to run in the GPU process, which is sandboxed.

The reason for using the GPU process is that CoreImage APIs seem
to depend strongly and mysteriously on the GPU, as I learned while
trying to get the unittests to work [1] in our normal mac bots (which
are virtual machines and have no GPU).  I tried using a sw rendering
context and a coupe of other circumventions but nothing really worked.

[1] early PSs in https://codereview.chromium.org/2677553003/

BUG=666143
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2739163003
Cr-Commit-Position: refs/heads/master@{#456555}
==========

to

==========
RELAND: Shape Detection: move the Mac service to the sandboxed GPU process

Original CL got reverted due to 
fast/shapedetection/shapedetection-security-test.html 
getting flaky on Mac bots; output logs said "gpu process crashed". 

This CL moves this test html to the normal (not-fast) test folder so 
it can use the Mojo mock instead of the real one in content_shell.
This is OK since the test essentially triggers rejection paths in Blink
code only.


Original CL description	 ------------------------------------------------

Shape Detection: move the Mac service to the sandboxed GPU process

ShapeDetection in Mac uses privileged and potentially dangerous APIs
inside CoreImage and perhaps more, transitively.  This CL moves the
shape detection service to run in the GPU process, which is sandboxed.

The reason for using the GPU process is that CoreImage APIs seem
to depend strongly and mysteriously on the GPU, as I learned while
trying to get the unittests to work [1] in our normal mac bots (which
are virtual machines and have no GPU).  I tried using a sw rendering
context and a coupe of other circumventions but nothing really worked.

[1] early PSs in https://codereview.chromium.org/2677553003/

BUG=666143
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2739163003
Cr-Commit-Position: refs/heads/master@{#456555}

TBR=rockot@chromium.org, rsesek@chromium.org, kbr@chromium.org
since the gist of the CL hasn't changed.
==========

[mcasas, 2017-03-17 00:13:39]

mcasas@chromium.org changed reviewers:
+ reillyg@chromium.org

[mcasas, 2017-03-17 00:13:39]

reillyg@ PTAL (semi trivial CL moving-around a LayoutTest)

[mcasas, 2017-03-17 00:16:27]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 00:17:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2017-03-17 01:05:10]

lgtm

[commit-bot: I haz the power, 2017-03-17 01:56:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 01:56:34]

Dry run: This issue passed the CQ dry run.

[mcasas, 2017-03-17 01:57:55]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-03-17 01:58:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 02:03:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489715875102980,
"parent_rev": "39c53dc5b763b6ac8e60c78ea32bb4e7ce7f009e", "commit_rev":
"73550c046bb7db4ee5af46e4a161946ddfe5ec3a"}

[commit-bot: I haz the power, 2017-03-17 02:04:25]

Description was changed from

==========
RELAND: Shape Detection: move the Mac service to the sandboxed GPU process

Original CL got reverted due to 
fast/shapedetection/shapedetection-security-test.html 
getting flaky on Mac bots; output logs said "gpu process crashed". 

This CL moves this test html to the normal (not-fast) test folder so 
it can use the Mojo mock instead of the real one in content_shell.
This is OK since the test essentially triggers rejection paths in Blink
code only.


Original CL description	 ------------------------------------------------

Shape Detection: move the Mac service to the sandboxed GPU process

ShapeDetection in Mac uses privileged and potentially dangerous APIs
inside CoreImage and perhaps more, transitively.  This CL moves the
shape detection service to run in the GPU process, which is sandboxed.

The reason for using the GPU process is that CoreImage APIs seem
to depend strongly and mysteriously on the GPU, as I learned while
trying to get the unittests to work [1] in our normal mac bots (which
are virtual machines and have no GPU).  I tried using a sw rendering
context and a coupe of other circumventions but nothing really worked.

[1] early PSs in https://codereview.chromium.org/2677553003/

BUG=666143
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2739163003
Cr-Commit-Position: refs/heads/master@{#456555}

TBR=rockot@chromium.org, rsesek@chromium.org, kbr@chromium.org
since the gist of the CL hasn't changed.
==========

to

==========
RELAND: Shape Detection: move the Mac service to the sandboxed GPU process

Original CL got reverted due to 
fast/shapedetection/shapedetection-security-test.html 
getting flaky on Mac bots; output logs said "gpu process crashed". 

This CL moves this test html to the normal (not-fast) test folder so 
it can use the Mojo mock instead of the real one in content_shell.
This is OK since the test essentially triggers rejection paths in Blink
code only.


Original CL description	 ------------------------------------------------

Shape Detection: move the Mac service to the sandboxed GPU process

ShapeDetection in Mac uses privileged and potentially dangerous APIs
inside CoreImage and perhaps more, transitively.  This CL moves the
shape detection service to run in the GPU process, which is sandboxed.

The reason for using the GPU process is that CoreImage APIs seem
to depend strongly and mysteriously on the GPU, as I learned while
trying to get the unittests to work [1] in our normal mac bots (which
are virtual machines and have no GPU).  I tried using a sw rendering
context and a coupe of other circumventions but nothing really worked.

[1] early PSs in https://codereview.chromium.org/2677553003/

BUG=666143
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2739163003
Cr-Commit-Position: refs/heads/master@{#456555}

TBR=rockot@chromium.org, rsesek@chromium.org, kbr@chromium.org
since the gist of the CL hasn't changed.

Review-Url: https://codereview.chromium.org/2756793002
Cr-Commit-Position: refs/heads/master@{#457656}
Committed:
https://chromium.googlesource.com/chromium/src/+/73550c046bb7db4ee5af46e4a161...
==========

[commit-bot: I haz the power, 2017-03-17 02:04:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/73550c046bb7db4ee5af46e4a161...