Remove command_buffer/common/types.h.

Remove command_buffer/common/types.h.

Make its current clients use base/macros.h and stdint.h instead.
No behavior change.

BUG=138542
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268315

[Nico, 2014-05-04 21:17:12]

This fixes the TODO from my last patch.

Is there a bug for generating all these autogenerated files at build time
instead of checking them into the tree already?

[piman, 2014-05-05 19:37:52]

On 2014/05/04 21:17:12, Nico wrote:
> This fixes the TODO from my last patch.
> 
> Is there a bug for generating all these autogenerated files at build time
> instead of checking them into the tree already?

TBH, I don't think we want to. We want to review changes to the command buffers
in the generated code (since they are security sensitive), and reviewing the
python script doesn't really make that practical.

[piman, 2014-05-05 19:37:54]

lgtm

https://codereview.chromium.org/268063002/diff/60001/mojo/public/c/gles2/gles...
File mojo/public/c/gles2/gles2_call_visitor_autogen.h (right):

https://codereview.chromium.org/268063002/diff/60001/mojo/public/c/gles2/gles...
mojo/public/c/gles2/gles2_call_visitor_autogen.h:180: VISIT_GL_CALL(GenBuffers,
void, (GLsizei n, GLuint * buffers), (n, buffers))
Bad clang format - https://code.google.com/p/chromium/issues/detail?id=365863

[Nico, 2014-05-05 20:14:57]

https://codereview.chromium.org/268063002/diff/60001/mojo/public/c/gles2/gles...
File mojo/public/c/gles2/gles2_call_visitor_autogen.h (right):

https://codereview.chromium.org/268063002/diff/60001/mojo/public/c/gles2/gles...
mojo/public/c/gles2/gles2_call_visitor_autogen.h:180: VISIT_GL_CALL(GenBuffers,
void, (GLsizei n, GLuint * buffers), (n, buffers))
On 2014/05/05 19:37:54, piman wrote:
> Bad clang format - https://code.google.com/p/chromium/issues/detail?id=365863

Ack. Do you want me to do something about this in this CL? (The file says "Do
not edit" above, and imo generated files shouldn't be checked in anyhow…)

[piman, 2014-05-05 21:07:18]

On 2014/05/05 20:14:57, Nico wrote:
>
https://codereview.chromium.org/268063002/diff/60001/mojo/public/c/gles2/gles...
> File mojo/public/c/gles2/gles2_call_visitor_autogen.h (right):
> 
>
https://codereview.chromium.org/268063002/diff/60001/mojo/public/c/gles2/gles...
> mojo/public/c/gles2/gles2_call_visitor_autogen.h:180:
VISIT_GL_CALL(GenBuffers,
> void, (GLsizei n, GLuint * buffers), (n, buffers))
> On 2014/05/05 19:37:54, piman wrote:
> > Bad clang format -
https://code.google.com/p/chromium/issues/detail?id=365863
> 
> Ack. Do you want me to do something about this in this CL?

On some other CLs, changes to that file were reverted, but I don't think that'll
scale moving forward, so might as well keep it as is.

> (The file says "Do
> not edit" above, and imo generated files shouldn't be checked in anyhow…)

See comments above as to why.
I don't have a problem with generated files being checked in, as long as it's
not part of the build.

[Nico, 2014-05-05 21:10:29]

On Mon, May 5, 2014 at 2:07 PM,  <piman@chromium.org> wrote:
> On 2014/05/05 20:14:57, Nico wrote:
>
>
https://codereview.chromium.org/268063002/diff/60001/mojo/public/c/gles2/gles...
>>
>> File mojo/public/c/gles2/gles2_call_visitor_autogen.h (right):
>
>
>
>
https://codereview.chromium.org/268063002/diff/60001/mojo/public/c/gles2/gles...
>>
>> mojo/public/c/gles2/gles2_call_visitor_autogen.h:180:
>
> VISIT_GL_CALL(GenBuffers,
>>
>> void, (GLsizei n, GLuint * buffers), (n, buffers))
>> On 2014/05/05 19:37:54, piman wrote:
>> > Bad clang format -
>
> https://code.google.com/p/chromium/issues/detail?id=365863
>
>> Ack. Do you want me to do something about this in this CL?
>
>
> On some other CLs, changes to that file were reverted, but I don't think
> that'll
> scale moving forward, so might as well keep it as is.
>
>
>> (The file says "Do
>> not edit" above, and imo generated files shouldn't be checked in
>> anyhow...)
>
>
> See comments above as to why.

Aha, I didn't see your first reply; gmail had collapsed it already for
some reason.

I don't find the "need to review diffs" argument super convincing (you
can still upload diffs for not-checked-in generated files, and the
blink binding guys can make it work somehow too…), but I won't press
this :-)

Thanks!

> I don't have a problem with generated files being checked in, as long as
> it's
> not part of the build.
>
>
>
> https://codereview.chromium.org/268063002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-05-05 21:10:45]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-05-05 21:12:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thakis@chromium.org/268063002/60001

[commit-bot: I haz the power, 2014-05-05 23:33:30]

Change committed as 268315