[bindings] Move callback functions from V8FooInternal namespace to V8Foo class

Convert exposed callback functions from V8FooInternal namespace to V8Foo
class's static methods.

Those functions are exposed and will be used from other .cpp files,
so it doesn't make sense to keep them in V8FooInternal namespace.

No behavior change.


BUG=617892
Review-Url: https://codereview.chromium.org/2653883006
Cr-Commit-Position: refs/heads/master@{#446301}
Committed: https://chromium.googlesource.com/chromium/src/+/32a27d38b42b99c1489221612aaa82142980b9d2

[peria, 2017-01-26 06:07:43]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 06:08:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[peria, 2017-01-26 07:31:11]

Description was changed from

==========
Move callback functions from V8FooInternal namespace to V8Foo class
as static functions.

BUG=None
==========

to

==========
Move callback functions from V8FooInternal namespace to V8Foo class
as static methods.

Those functions are exposed and will be used from other .cpp files,
so it doesn't make sense to keep them in V8FooInternal namespace.


BUG=None
==========

[peria, 2017-01-26 07:32:00]

Description was changed from

==========
Move callback functions from V8FooInternal namespace to V8Foo class
as static methods.

Those functions are exposed and will be used from other .cpp files,
so it doesn't make sense to keep them in V8FooInternal namespace.


BUG=None
==========

to

==========
Convert exposed callback functions from V8FooInternal namespace to V8Foo
class's static methods.

Those functions are exposed and will be used from other .cpp files,
so it doesn't make sense to keep them in V8FooInternal namespace.


BUG=None
==========

[peria, 2017-01-26 07:46:41]

Description was changed from

==========
Convert exposed callback functions from V8FooInternal namespace to V8Foo
class's static methods.

Those functions are exposed and will be used from other .cpp files,
so it doesn't make sense to keep them in V8FooInternal namespace.


BUG=None
==========

to

==========
Convert exposed callback functions from V8FooInternal namespace to V8Foo
class's static methods.

Those functions are exposed and will be used from other .cpp files,
so it doesn't make sense to keep them in V8FooInternal namespace.

No behavior change.


BUG=None
==========

[peria, 2017-01-26 07:47:54]

peria@chromium.org changed reviewers:
+ bashi@chromium.org, haraken@chromium.org, yukishiino@chromium.org

[peria, 2017-01-26 07:47:55]

PTL

[peria, 2017-01-26 07:56:31]

Description was changed from

==========
Convert exposed callback functions from V8FooInternal namespace to V8Foo
class's static methods.

Those functions are exposed and will be used from other .cpp files,
so it doesn't make sense to keep them in V8FooInternal namespace.

No behavior change.


BUG=None
==========

to

==========
Convert exposed callback functions from V8FooInternal namespace to V8Foo
class's static methods.

Those functions are exposed and will be used from other .cpp files,
so it doesn't make sense to keep them in V8FooInternal namespace.

No behavior change.


BUG=617892
==========

[peria, 2017-01-26 08:00:11]

I forgot to note, this CL also removs a template block "event_constructor" in
interface_base.cpp.tmpl, which has no contents and has no replacements.

[Yuki, 2017-01-26 08:01:35]

LGTM.

https://codereview.chromium.org/2653883006/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/interface.h.tmpl (right):

https://codereview.chromium.org/2653883006/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/interface.h.tmpl:28: class
{{v8_class}} {
If no one has an objection, I'd slightly prefer adding {{exported}} to the
class, instead of adding it to each member function, because there are so many
members.

https://codereview.chromium.org/2653883006/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/interface.h.tmpl:171: // Callback
functions
Probably, it's a little cleaner to put these members in private: than to putthem
in public:.  You can make your snapshot creater a friend class.

If it's a headache for you to make them private:, I'm fine with this change as
is.

[commit-bot: I haz the power, 2017-01-26 08:05:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 08:05:06]

Dry run: This issue passed the CQ dry run.

[bashi, 2017-01-26 08:22:10]

lgtm

https://codereview.chromium.org/2653883006/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/interface.h.tmpl (right):

https://codereview.chromium.org/2653883006/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/interface.h.tmpl:28: class
{{v8_class}} {
On 2017/01/26 08:01:35, Yuki wrote:
> If no one has an objection, I'd slightly prefer adding {{exported}} to the
> class, instead of adding it to each member function, because there are so many
> members.

IIUC tasak@ tried hard to minimize the number of exported symbols. However,
given that we are going to expose many symbols, putting {{exported}} on the
class would make sense.

[peria, 2017-01-26 08:31:57]

The CQ bit was checked by peria@chromium.org

[peria, 2017-01-26 08:31:57]

The patchset sent to the CQ was uploaded after l-g-t-m from bashi@chromium.org,
yukishiino@chromium.org
Link to the patchset: https://codereview.chromium.org/2653883006/#ps10001
(title: "Change export")

[commit-bot: I haz the power, 2017-01-26 08:32:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 08:34:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 08:34:31]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[peria, 2017-01-26 08:44:52]

https://codereview.chromium.org/2653883006/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/interface.h.tmpl (right):

https://codereview.chromium.org/2653883006/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/interface.h.tmpl:28: class
{{v8_class}} {
On 2017/01/26 08:01:35, Yuki wrote:
> If no one has an objection, I'd slightly prefer adding {{exported}} to the
> class, instead of adding it to each member function, because there are so many
> members.

+1.
Done.

Keep partial interface classes non exported.

https://codereview.chromium.org/2653883006/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/interface.h.tmpl:171: // Callback
functions
On 2017/01/26 08:01:35, Yuki wrote:
> Probably, it's a little cleaner to put these members in private: than to
putthem
> in public:.  You can make your snapshot creater a friend class.
> 
> If it's a headache for you to make them private:, I'm fine with this change as
> is.

It seems difficult because some functions are accessed in V8FooInternal, e.g.
kCrossOriginAttributeTable.
Let me keep this as-is.

[peria, 2017-01-26 08:44:59]

The CQ bit was checked by peria@chromium.org

[peria, 2017-01-26 08:45:00]

The patchset sent to the CQ was uploaded after l-g-t-m from bashi@chromium.org,
yukishiino@chromium.org
Link to the patchset: https://codereview.chromium.org/2653883006/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-26 08:45:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 09:18:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 09:18:48]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[peria, 2017-01-26 09:33:32]

The CQ bit was checked by peria@chromium.org

[peria, 2017-01-26 09:33:33]

The patchset sent to the CQ was uploaded after l-g-t-m from bashi@chromium.org,
yukishiino@chromium.org
Link to the patchset: https://codereview.chromium.org/2653883006/#ps30001
(title: "Revert expose change")

[commit-bot: I haz the power, 2017-01-26 09:33:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[peria, 2017-01-26 09:35:24]

https://codereview.chromium.org/2653883006/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/interface.h.tmpl (right):

https://codereview.chromium.org/2653883006/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/interface.h.tmpl:28: class
{{v8_class}} {
On 2017/01/26 08:44:52, peria wrote:
> On 2017/01/26 08:01:35, Yuki wrote:
> > If no one has an objection, I'd slightly prefer adding {{exported}} to the
> > class, instead of adding it to each member function, because there are so
many
> > members.
> 
> +1.
> Done.
> 
> Keep partial interface classes non exported.

Changing scope of {{exposed}} seems to violate visibility.
Reverted this change.

[haraken, 2017-01-26 09:35:41]

LGTM

[commit-bot: I haz the power, 2017-01-26 10:56:34]

CQ is committing da patch.

Bot data: {"patchset_id": 30001, "attempt_start_ts": 1485423212487000,
"parent_rev": "f0e87360ae1a1dfae4bf0deb8cacd9db5a785466", "commit_rev":
"32a27d38b42b99c1489221612aaa82142980b9d2"}

[commit-bot: I haz the power, 2017-01-26 10:57:06]

Description was changed from

==========
Convert exposed callback functions from V8FooInternal namespace to V8Foo
class's static methods.

Those functions are exposed and will be used from other .cpp files,
so it doesn't make sense to keep them in V8FooInternal namespace.

No behavior change.


BUG=617892
==========

to

==========
Convert exposed callback functions from V8FooInternal namespace to V8Foo
class's static methods.

Those functions are exposed and will be used from other .cpp files,
so it doesn't make sense to keep them in V8FooInternal namespace.

No behavior change.


BUG=617892

Review-Url: https://codereview.chromium.org/2653883006
Cr-Commit-Position: refs/heads/master@{#446301}
Committed:
https://chromium.googlesource.com/chromium/src/+/32a27d38b42b99c1489221612aaa...
==========

[commit-bot: I haz the power, 2017-01-26 10:57:08]

Committed patchset #4 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/32a27d38b42b99c1489221612aaa...