third_party/WebKit/Source/bindings/templates/constants.cpp.tmpl - Issue 2653883006: [bindings] Move callback functions from V8FooInternal namespace to V8Foo class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/constants.cpp.tmpl

Issue 2653883006: [bindings] Move callback functions from V8FooInternal namespace to V8Foo class (Closed)

Patch Set: Revert expose change Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl ('k') | third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/constants.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/constants.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/constants.cpp.tmpl

index c49a23826a9f53dfdca6a60630f03f7083ef33c5..9940b50bd4bd13970ab248e2a36e5455261ea153 100644

--- a/third_party/WebKit/Source/bindings/templates/constants.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/constants.cpp.tmpl

@@ -1,6 +1,6 @@

{##############################################################################}

{% macro constant_getter_callback(constant) %}

-{{exported}}void {{constant.name}}ConstantGetterCallback(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>& info) {

+void {{v8_class_or_partial}}::{{constant.name}}ConstantGetterCallback(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>& info) {

{% if constant.deprecate_as %}

Deprecation::countDeprecation(currentExecutionContext(info.GetIsolate()), UseCounter::{{constant.deprecate_as}});

{% endif %}

@@ -41,7 +41,7 @@ V8DOMConfiguration::installConstant(isolate, interfaceTemplate, prototypeTemplat

{% endfor %}

{# Constants with [DeprecateAs] or [MeasureAs] #}

{% for constant in constants | has_special_getter %}

-V8DOMConfiguration::installConstantWithGetter(isolate, interfaceTemplate, prototypeTemplate, "{{constant.name}}", {{cpp_class}}V8Internal::{{constant.name}}ConstantGetterCallback);

+V8DOMConfiguration::installConstantWithGetter(isolate, interfaceTemplate, prototypeTemplate, "{{constant.name}}", {{v8_class_or_partial}}::{{constant.name}}ConstantGetterCallback);

{% endfor %}

{# Check constants #}

{% if not do_not_check_constants %}