Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp

Issue 2653883006: [bindings] Move callback functions from V8FooInternal namespace to V8Foo class (Closed)
Patch Set: Revert expose change Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp
index 7979a0f3ed744190041e05f14b3c65c85043de7e..ab84b81bb9f93ac44888485166e4f72c2a8b142c 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp
@@ -61,10 +61,6 @@ static void readonlyUnsignedShortAttributeAttributeGetter(const v8::FunctionCall
v8SetReturnValueUnsigned(info, impl->readonlyUnsignedShortAttribute());
}
-CORE_EXPORT void readonlyUnsignedShortAttributeAttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {
- TestExceptionV8Internal::readonlyUnsignedShortAttributeAttributeGetter(info);
-}
-
static void readonlyStringAttributeAttributeGetter(const v8::FunctionCallbackInfo<v8::Value>& info) {
v8::Local<v8::Object> holder = info.Holder();
@@ -73,20 +69,12 @@ static void readonlyStringAttributeAttributeGetter(const v8::FunctionCallbackInf
v8SetReturnValueString(info, impl->readonlyStringAttribute(), info.GetIsolate());
}
-CORE_EXPORT void readonlyStringAttributeAttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {
- TestExceptionV8Internal::readonlyStringAttributeAttributeGetter(info);
-}
-
static void toStringMethod(const v8::FunctionCallbackInfo<v8::Value>& info) {
TestException* impl = V8TestException::toImpl(info.Holder());
v8SetReturnValueString(info, impl->toString(), info.GetIsolate());
}
-CORE_EXPORT void toStringMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {
- TestExceptionV8Internal::toStringMethod(info);
-}
-
static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info) {
ExceptionState exceptionState(info.GetIsolate(), ExceptionState::ConstructionContext, "TestException");
@@ -108,13 +96,25 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info) {
} // namespace TestExceptionV8Internal
+void V8TestException::readonlyUnsignedShortAttributeAttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {
+ TestExceptionV8Internal::readonlyUnsignedShortAttributeAttributeGetter(info);
+}
+
+void V8TestException::readonlyStringAttributeAttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {
+ TestExceptionV8Internal::readonlyStringAttributeAttributeGetter(info);
+}
+
+void V8TestException::toStringMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {
+ TestExceptionV8Internal::toStringMethod(info);
+}
+
const V8DOMConfiguration::AccessorConfiguration V8TestExceptionAccessors[] = {
- {"readonlyUnsignedShortAttribute", TestExceptionV8Internal::readonlyUnsignedShortAttributeAttributeGetterCallback, 0, 0, 0, nullptr, 0, static_cast<v8::PropertyAttribute>(v8::ReadOnly), V8DOMConfiguration::OnPrototype, V8DOMConfiguration::CheckHolder},
- {"readonlyStringAttribute", TestExceptionV8Internal::readonlyStringAttributeAttributeGetterCallback, 0, 0, 0, nullptr, 0, static_cast<v8::PropertyAttribute>(v8::ReadOnly), V8DOMConfiguration::OnPrototype, V8DOMConfiguration::CheckHolder},
+ {"readonlyUnsignedShortAttribute", V8TestException::readonlyUnsignedShortAttributeAttributeGetterCallback, nullptr, nullptr, nullptr, nullptr, nullptr, static_cast<v8::PropertyAttribute>(v8::ReadOnly), V8DOMConfiguration::OnPrototype, V8DOMConfiguration::CheckHolder},
+ {"readonlyStringAttribute", V8TestException::readonlyStringAttributeAttributeGetterCallback, nullptr, nullptr, nullptr, nullptr, nullptr, static_cast<v8::PropertyAttribute>(v8::ReadOnly), V8DOMConfiguration::OnPrototype, V8DOMConfiguration::CheckHolder},
};
const V8DOMConfiguration::MethodConfiguration V8TestExceptionMethods[] = {
- {"toString", TestExceptionV8Internal::toStringMethodCallback, 0, 0, static_cast<v8::PropertyAttribute>(v8::DontEnum), V8DOMConfiguration::OnPrototype, V8DOMConfiguration::CheckHolder},
+ {"toString", V8TestException::toStringMethodCallback, nullptr, 0, static_cast<v8::PropertyAttribute>(v8::DontEnum), V8DOMConfiguration::OnPrototype, V8DOMConfiguration::CheckHolder},
};
void V8TestException::constructorCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {

Powered by Google App Engine
This is Rietveld 408576698