Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp

Issue 2653883006: [bindings] Move callback functions from V8FooInternal namespace to V8Foo class (Closed)
Patch Set: Revert expose change Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp b/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp
index fdd8eb1e4ef64f3d23f7ac9df768e809d8c7ff35..0723b3adc14a0c55243eb30f7dbdc519791b5f96 100644
--- a/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp
@@ -45,10 +45,6 @@ static void voidMethodPartial1Method(const v8::FunctionCallbackInfo<v8::Value>&
TestInterface2Partial::voidMethodPartial1(*impl, value);
}
- void voidMethodPartial1MethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {
- TestInterface2PartialV8Internal::voidMethodPartial1Method(info);
-}
-
static void voidMethodPartial2Method(const v8::FunctionCallbackInfo<v8::Value>& info) {
TestInterface2* impl = V8TestInterface2::toImpl(info.Holder());
@@ -65,14 +61,18 @@ static void voidMethodPartial2Method(const v8::FunctionCallbackInfo<v8::Value>&
TestInterface2Partial2::voidMethodPartial2(*impl, value);
}
- void voidMethodPartial2MethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {
- TestInterface2PartialV8Internal::voidMethodPartial2Method(info);
+} // namespace TestInterface2PartialV8Internal
+
+void V8TestInterface2Partial::voidMethodPartial1MethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {
+ TestInterface2PartialV8Internal::voidMethodPartial1Method(info);
}
-} // namespace TestInterface2PartialV8Internal
+void V8TestInterface2Partial::voidMethodPartial2MethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {
+ TestInterface2PartialV8Internal::voidMethodPartial2Method(info);
+}
const V8DOMConfiguration::MethodConfiguration V8TestInterface2Methods[] = {
- {"voidMethodPartial2", TestInterface2PartialV8Internal::voidMethodPartial2MethodCallback, 0, 1, v8::None, V8DOMConfiguration::OnPrototype, V8DOMConfiguration::CheckHolder},
+ {"voidMethodPartial2", V8TestInterface2Partial::voidMethodPartial2MethodCallback, nullptr, 1, v8::None, V8DOMConfiguration::OnPrototype, V8DOMConfiguration::CheckHolder},
};
void V8TestInterface2Partial::installV8TestInterface2Template(v8::Isolate* isolate, const DOMWrapperWorld& world, v8::Local<v8::FunctionTemplate> interfaceTemplate) {
@@ -90,7 +90,7 @@ void V8TestInterface2Partial::installV8TestInterface2Template(v8::Isolate* isola
V8DOMConfiguration::installMethods(isolate, world, instanceTemplate, prototypeTemplate, interfaceTemplate, signature, V8TestInterface2Methods, WTF_ARRAY_LENGTH(V8TestInterface2Methods));
if (RuntimeEnabledFeatures::interface2PartialFeatureNameEnabled()) {
- const V8DOMConfiguration::MethodConfiguration voidMethodPartial1MethodConfiguration = {"voidMethodPartial1", TestInterface2PartialV8Internal::voidMethodPartial1MethodCallback, 0, 1, v8::None, V8DOMConfiguration::OnPrototype, V8DOMConfiguration::CheckHolder};
+ const V8DOMConfiguration::MethodConfiguration voidMethodPartial1MethodConfiguration = {"voidMethodPartial1", V8TestInterface2Partial::voidMethodPartial1MethodCallback, nullptr, 1, v8::None, V8DOMConfiguration::OnPrototype, V8DOMConfiguration::CheckHolder};
V8DOMConfiguration::installMethod(isolate, world, instanceTemplate, prototypeTemplate, interfaceTemplate, signature, voidMethodPartial1MethodConfiguration);
}
}

Powered by Google App Engine
This is Rietveld 408576698