[bindings] Move callback functions from V8FooInternal namespace to V8Foo class

third_party/WebKit/Source/bindings/templates/interface.h.tmpl

 {% filter format_blink_cpp_source_code %}
 
 {% include 'copyright_block.txt' %}
 #ifndef {{v8_class}}_h
 #define {{v8_class}}_h
 
 {% for filename in header_includes %}
 #include "{{filename}}"
 {% endfor %}
 
 namespace blink {
 
 {% if has_event_constructor %}
 class Dictionary;
 {% endif %}
 {% if origin_trial_attributes %}
 class ScriptState;
 {% endif %}
 {% if named_constructor %}
 class {{v8_class}}Constructor {
   STATIC_ONLY({{v8_class}}Constructor);
  public:
   static v8::Local<v8::FunctionTemplate> domTemplate(v8::Isolate*, const DOMWrapperWorld&);
   {{exported}}static const WrapperTypeInfo wrapperTypeInfo;
 };
 
 {% endif %}
 class {{v8_class}} {

[Yuki, 2017/01/26 08:01:35]

If no one has an objection, I'd slightly prefer adding {{exported}} to the
class, instead of adding it to each member function, because there are so many
members.

[bashi, 2017/01/26 08:22:10]

IIUC tasak@ tried hard to minimize the number of exported symbols. However,
given that we are going to expose many symbols, putting {{exported}} on the
class would make sense.

[peria, 2017/01/26 08:44:52]

+1.
Done.

Keep partial interface classes non exported.

[peria, 2017/01/26 09:35:24]

Changing scope of {{exposed}} seems to violate visibility.
Reverted this change.

   STATIC_ONLY({{v8_class}});
  public:
   {% if is_array_buffer_or_view %}
   {{exported}}static {{cpp_class}}* toImpl(v8::Local<v8::Object> object);
   {% else %}
   {{exported}}static bool hasInstance(v8::Local<v8::Value>, v8::Isolate*);
   static v8::Local<v8::Object> findInstanceInPrototypeChain(v8::Local<v8::Value>, v8::Isolate*);
   {{exported}}static v8::Local<v8::FunctionTemplate> domTemplate(v8::Isolate*, const DOMWrapperWorld&);
   {% if has_named_properties_object %}
   {{exported}}static v8::Local<v8::FunctionTemplate> domTemplateForNamedPropertiesObject(v8::Isolate*, const DOMWrapperWorld&);
@@ skipping 121 matching lines @@
   {% endif %}
 
   {% for feature in origin_trial_features %}
 
   static void install{{feature.name}}(v8::Isolate*, const DOMWrapperWorld&, v8::Local<v8::Object> instance, v8::Local<v8::Object> prototype, v8::Local<v8::Function> interface);
   static void install{{feature.name}}(ScriptState*, v8::Local<v8::Object> instance);
   {% if not feature.needs_instance %}
   static void install{{feature.name}}(ScriptState*);
   {% endif %}
   {% endfor %}
+
+  // Callback functions

[Yuki, 2017/01/26 08:01:35]

Probably, it's a little cleaner to put these members in private: than to putthem
in public:.  You can make your snapshot creater a friend class.

If it's a headache for you to make them private:, I'm fine with this change as
is.

[peria, 2017/01/26 08:44:52]

It seems difficult because some functions are accessed in V8FooInternal, e.g.
kCrossOriginAttributeTable.
Let me keep this as-is.

+  {% for constant in constants | has_special_getter %}
+  {{exported}}static void {{constant.name}}ConstantGetterCallback(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>&);
+  {% endfor %}
+
+  {% for attribute in attributes %}
+  {% if attribute.is_cached_accessor %}
+  {{exported}}static v8::Local<v8::Private> {{attribute.name}}CachedAccessorCallback(v8::Isolate*);
+  {% endif %}
+  {% for world_suffix in attribute.world_suffixes %}
+  {% if not attribute.constructor_type %}
+  {{exported}}static void {{attribute.name}}AttributeGetterCallback{{world_suffix}}(
+    {%- if attribute.is_data_type_property -%}
+    v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>&
+    {%- else -%}
+    const v8::FunctionCallbackInfo<v8::Value>&
+    {%- endif -%});
+  {% elif attribute.needs_constructor_getter_callback %}
+  {{exported}}static void {{attribute.name}}ConstructorGetterCallback{{world_suffix}}(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>&);
+  {% endif %}
+  {% if attribute.has_setter %}
+  {{exported}}static void {{attribute.name}}AttributeSetterCallback{{world_suffix}}(
+    {%- if attribute.is_data_type_property -%}
+    v8::Local<v8::Name>, v8::Local<v8::Value>, const v8::PropertyCallbackInfo<void>&
+    {%- else -%}
+    const v8::FunctionCallbackInfo<v8::Value>&
+    {%- endif -%});
+  {% endif %}
+  {% endfor %}
+  {% endfor %}
+
+  {% for method in methods %}
+  {% for world_suffix in method.world_suffixes %}
+  {% if not method.overload_index or method.overloads %}
+  {# Document about the following condition: #}
+  {# https://docs.google.com/document/d/1qBC7Therp437Jbt_QYAtNYMZs6zQ_7_tnMkNUG_ACqs/edit?usp=sharing #}
+  {% if (method.overloads and method.overloads.visible and
+         (not method.overloads.has_partial_overloads or not is_partial)) or
+        (not method.overloads and method.visible) %}
+  {# A single callback is generated for overloaded methods #}
+  {# with considering partial overloads #}
+  {{exported}}static void {{method.name}}MethodCallback{{world_suffix}}(const v8::FunctionCallbackInfo<v8::Value>&);
+  {% endif %}
+  {% endif %}
+  {% if method.is_cross_origin and method.visible %}
+  {{exported}}static void {{method.name}}OriginSafeMethodGetterCallback{{world_suffix}}(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>&);
+  {% endif %}
+  {% endfor %}
+  {% endfor %}
+  {% if iterator_method %}
+  {{exported}}static void {{iterator_method.name}}MethodCallback(const v8::FunctionCallbackInfo<v8::Value>&);
+  {% endif %}
+  {% if has_origin_safe_method_setter %}
+  {{exported}}static void {{cpp_class}}OriginSafeMethodSetterCallback(v8::Local<v8::Name>, v8::Local<v8::Value>, const v8::PropertyCallbackInfo<void>&);
+  {% endif %}
+
+  {% if has_access_check_callbacks and not is_partial %}
+  {{exported}}static bool securityCheck(v8::Local<v8::Context>, v8::Local<v8::Object>, v8::Local<v8::Value>);
+  {% if has_cross_origin_named_getter %}
+  {{exported}}static void crossOriginNamedGetter(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>&);
+  {% endif %}
+  {% if has_cross_origin_named_setter %}
+  {{exported}}static void crossOriginNamedSetter(v8::Local<v8::Name>, v8::Local<v8::Value>, const v8::PropertyCallbackInfo<v8::Value>&);
+  {% endif %}
+  {% if has_cross_origin_named_enumerator %}
+  {{exported}}static void crossOriginNamedEnumerator(const v8::PropertyCallbackInfo<v8::Array>&);
+  {% endif %}
+  {% if has_cross_origin_indexed_getter %}
+  {{exported}}static void crossOriginIndexedGetter(uint32_t index, const v8::PropertyCallbackInfo<v8::Value>&);
+  {% endif %}
+  {% endif %}
+
+  {% if named_property_getter %}
+  {{exported}}static void namedPropertyGetterCallback(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>&);
+  {% endif %}
+  {% if named_property_setter %}
+  {{exported}}static void namedPropertySetterCallback(v8::Local<v8::Name>, v8::Local<v8::Value>, const v8::PropertyCallbackInfo<v8::Value>&);
+  {% endif %}
+  {% if named_property_deleter %}
+  {{exported}}static void namedPropertyDeleterCallback(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Boolean>&);
+  {% endif %}
+  {% if named_property_getter and named_property_getter.is_enumerable %}
+  {{exported}}static void namedPropertyQueryCallback(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Integer>&);
+  {% endif %}
+  {% if named_property_getter and named_property_getter.is_enumerable %}
+  {{exported}}static void namedPropertyEnumeratorCallback(const v8::PropertyCallbackInfo<v8::Array>&);
+  {% endif %}
+  {% if indexed_property_getter or named_property_getter %}
+  {{exported}}static void indexedPropertyGetterCallback(uint32_t index, const v8::PropertyCallbackInfo<v8::Value>&);
+  {% endif %}
+  {% if indexed_property_setter or named_property_setter %}
+  {{exported}}static void indexedPropertySetterCallback(uint32_t index, v8::Local<v8::Value>, const v8::PropertyCallbackInfo<v8::Value>&);
+  {% endif %}
+  {% if indexed_property_deleter or named_property_deleter %}
+  {{exported}}static void indexedPropertyDeleterCallback(uint32_t index, const v8::PropertyCallbackInfo<v8::Boolean>&);
+  {% endif %}
+
   {% if has_partial_interface %}
-
  private:
   static InstallTemplateFunction install{{v8_class}}TemplateFunction;
   {% endif %}
 };
 
 {% if has_event_constructor %}
 {{exported}}bool initialize{{cpp_class}}({{cpp_class}}Init&, const Dictionary&, ExceptionState&, const v8::FunctionCallbackInfo<v8::Value>& info);
 
 {% endif %}
 template <>
 struct V8TypeOf<{{cpp_class}}> {
   typedef {{v8_class}} Type;
 };
 
 }  // namespace blink
 
 #endif  // {{v8_class}}_h
 
 {% endfilter %}{# format_blink_cpp_source_code #}